cterdam commited on
Commit
b4362a5
·
1 Parent(s): 5b82264

Load region→lang mapping from cterdam/iso_3166-1_alpha-2

Browse files

Replace hardcoded SLAVIC_REGIONS / SINOPHONE_REGIONS sets with a
session-scoped fixture that loads the authoritative mapping directly
from cterdam/iso_3166-1_alpha-2, as documented in the README.

Files changed (1) hide show
  1. test/test_invariants.py +11 -23
test/test_invariants.py CHANGED
@@ -24,24 +24,12 @@ import pytest
24
  from collections import defaultdict
25
  from datasets import load_dataset
26
 
27
- SLAVIC_REGIONS = {
28
- 'RU', 'UA', 'BY', 'KZ', 'UZ', 'TJ', 'KG', 'TM', 'GE', 'AZ', 'AM', 'MD',
29
- 'LT', 'LV', 'EE', 'RS', 'ME', 'BA', 'HR', 'SI', 'SK', 'CZ', 'PL', 'BG', 'MK', 'FI'
30
- }
31
 
32
- SINOPHONE_REGIONS = {
33
- 'CN', 'TW', 'HK', 'MO', 'JP', 'KR', 'KP', 'MN', 'SG', 'VN', 'LA', 'TH', 'MM', 'KH', 'MY', 'BN'
34
- }
35
-
36
-
37
- def determine_expected_lang(region_code: str) -> str:
38
- """Determine expected lang from region code."""
39
- if region_code in SINOPHONE_REGIONS:
40
- return 'zh'
41
- elif region_code in SLAVIC_REGIONS:
42
- return 'ru'
43
- else:
44
- return 'en'
45
 
46
 
47
  @pytest.fixture(scope="session")
@@ -78,17 +66,17 @@ def test_name_matches_lang_field(dataset):
78
  assert mismatches == [], f"Name/lang field mismatches: {mismatches}"
79
 
80
 
81
- def test_lang_matches_region(dataset):
82
- """lang field must match region's language rule."""
83
  mismatches = []
84
 
85
  for i, entry in enumerate(dataset):
86
- region = entry.get('region')
87
  lang = entry.get('lang')
88
- expected_lang = determine_expected_lang(region)
89
 
90
- if lang != expected_lang:
91
- mismatches.append((i, entry.get('code'), region, lang, expected_lang))
92
  if len(mismatches) >= 5:
93
  break
94
 
 
24
  from collections import defaultdict
25
  from datasets import load_dataset
26
 
 
 
 
 
27
 
28
+ @pytest.fixture(scope="session")
29
+ def region_lang():
30
+ """Load region→lang mapping from cterdam/iso_3166-1_alpha-2 (authoritative)."""
31
+ ds = load_dataset('cterdam/iso_3166-1_alpha-2', split='train')
32
+ return {r['code']: r['lang'] for r in ds if r.get('lang')}
 
 
 
 
 
 
 
 
33
 
34
 
35
  @pytest.fixture(scope="session")
 
66
  assert mismatches == [], f"Name/lang field mismatches: {mismatches}"
67
 
68
 
69
+ def test_lang_matches_region(dataset, region_lang):
70
+ """lang field must match cterdam/iso_3166-1_alpha-2 for that region."""
71
  mismatches = []
72
 
73
  for i, entry in enumerate(dataset):
74
+ region = entry.get('region') or ''
75
  lang = entry.get('lang')
76
+ expected = region_lang.get(region, 'en')
77
 
78
+ if lang != expected:
79
+ mismatches.append((i, entry.get('code'), region, lang, expected))
80
  if len(mismatches) >= 5:
81
  break
82