cterdam commited on
Commit
79f0dee
·
verified ·
1 Parent(s): 8775780

[iata-metro] remove hash invariant tests

Browse files
Files changed (1) hide show
  1. test/test_invariants.py +10 -44
test/test_invariants.py CHANGED
@@ -7,12 +7,10 @@ Run from dataset root after cloning:
7
 
8
  Verifies:
9
  - name field matches lang selection (name_en/ru/zh)
10
- - hash = SHA256(name)
11
  - lang matches region-based language rule
12
- - hash format is 64-char hex string
13
  """
14
 
15
- import hashlib
16
  import pytest
17
  from datasets import load_dataset
18
 
@@ -48,74 +46,43 @@ def test_lang_values_valid(dataset):
48
  assert invalid == [], f"Invalid lang values: {invalid[:5]}"
49
 
50
 
51
- def test_hash_format_valid(dataset):
52
- """hash field must be 64-char hex string (if name exists)."""
53
- invalid = [
54
- (i, e['hash'])
55
- for i, e in enumerate(dataset)
56
- if e.get('hash') is not None and not (
57
- isinstance(e['hash'], str) and
58
- len(e['hash']) == 64 and
59
- all(c in '0123456789abcdef' for c in e['hash'])
60
- )
61
- ]
62
- assert invalid == [], f"Invalid hash format: {invalid[:5]}"
63
-
64
-
65
  def test_name_matches_lang_field(dataset):
66
  """name field must equal name_en/ru/zh based on lang."""
67
  lang_to_field = {'en': 'name_en', 'ru': 'name_ru', 'zh': 'name_zh'}
68
  mismatches = []
69
-
70
  for i, entry in enumerate(dataset):
71
  name = entry.get('name')
72
  lang = entry.get('lang')
73
  if not name or not lang:
74
  continue
75
-
76
  field_name = lang_to_field.get(lang)
77
  lang_field_value = entry.get(field_name)
78
-
79
  if name != lang_field_value:
80
  mismatches.append((i, entry.get('code'), lang, name[:20], lang_field_value[:20] if lang_field_value else None))
81
  if len(mismatches) >= 5:
82
  break
83
-
84
- assert mismatches == [], f"Name/lang field mismatches: {mismatches}"
85
 
86
-
87
- def test_hash_matches_name(dataset):
88
- """hash field must equal SHA256(name)."""
89
- mismatches = []
90
-
91
- for i, entry in enumerate(dataset):
92
- name = entry.get('name')
93
- stored_hash = entry.get('hash')
94
- if name and stored_hash:
95
- expected_hash = hashlib.sha256(name.encode()).hexdigest()
96
- if stored_hash != expected_hash:
97
- mismatches.append((i, entry.get('code'), stored_hash[:8], expected_hash[:8]))
98
- if len(mismatches) >= 5:
99
- break
100
-
101
- assert mismatches == [], f"Hash mismatches: {mismatches}"
102
 
103
 
104
  def test_lang_matches_region(dataset):
105
  """lang field must match region's language rule."""
106
  mismatches = []
107
-
108
  for i, entry in enumerate(dataset):
109
  region = entry.get('region')
110
  lang = entry.get('lang')
111
  expected_lang = determine_expected_lang(region)
112
-
113
  if lang != expected_lang:
114
  mismatches.append((i, entry.get('code'), region, lang, expected_lang))
115
  if len(mismatches) >= 5:
116
  break
117
-
118
- assert mismatches == [], f"Lang mismatches: {{mismatches}}"
119
 
120
 
121
  def test_coordinates_valid(dataset):
@@ -126,5 +93,4 @@ def test_coordinates_valid(dataset):
126
  if (e.get('lat') is not None and (e['lat'] < -90 or e['lat'] > 90)) or
127
  (e.get('lon') is not None and (e['lon'] < -180 or e['lon'] > 180))
128
  ]
129
- assert invalid == [], f"Invalid coordinates: {{invalid[:5]}}"
130
-
 
7
 
8
  Verifies:
9
  - name field matches lang selection (name_en/ru/zh)
 
10
  - lang matches region-based language rule
11
+ - coordinates are in valid range
12
  """
13
 
 
14
  import pytest
15
  from datasets import load_dataset
16
 
 
46
  assert invalid == [], f"Invalid lang values: {invalid[:5]}"
47
 
48
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
49
  def test_name_matches_lang_field(dataset):
50
  """name field must equal name_en/ru/zh based on lang."""
51
  lang_to_field = {'en': 'name_en', 'ru': 'name_ru', 'zh': 'name_zh'}
52
  mismatches = []
53
+
54
  for i, entry in enumerate(dataset):
55
  name = entry.get('name')
56
  lang = entry.get('lang')
57
  if not name or not lang:
58
  continue
59
+
60
  field_name = lang_to_field.get(lang)
61
  lang_field_value = entry.get(field_name)
62
+
63
  if name != lang_field_value:
64
  mismatches.append((i, entry.get('code'), lang, name[:20], lang_field_value[:20] if lang_field_value else None))
65
  if len(mismatches) >= 5:
66
  break
 
 
67
 
68
+ assert mismatches == [], f"Name/lang field mismatches: {mismatches}"
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
69
 
70
 
71
  def test_lang_matches_region(dataset):
72
  """lang field must match region's language rule."""
73
  mismatches = []
74
+
75
  for i, entry in enumerate(dataset):
76
  region = entry.get('region')
77
  lang = entry.get('lang')
78
  expected_lang = determine_expected_lang(region)
79
+
80
  if lang != expected_lang:
81
  mismatches.append((i, entry.get('code'), region, lang, expected_lang))
82
  if len(mismatches) >= 5:
83
  break
84
+
85
+ assert mismatches == [], f"Lang mismatches: {mismatches}"
86
 
87
 
88
  def test_coordinates_valid(dataset):
 
93
  if (e.get('lat') is not None and (e['lat'] < -90 or e['lat'] > 90)) or
94
  (e.get('lon') is not None and (e['lon'] < -180 or e['lon'] > 180))
95
  ]
96
+ assert invalid == [], f"Invalid coordinates: {invalid[:5]}"