# rrv_core - Add a assertion for illegal memory access region.

- Source URL: https://github.com/FPGA-MAFIA/fpga_mafia/issues/498

We should add an assertion making sure that if we have a load/store its for a d_mem/cr/vga region..
(this would ease debugging when the SW tries to access the wrong memory space completely.. )

PR Title: add assertion when accessing address out of range
PR Number: #559
Status: Merged
Author: roman012285
Reviewer/Merger: amichai-bd
Merge Date: March 13, 2024

Description:
No formal description was provided by the author.

Key Comments:
amichai-bd's Initial Review Questions:
- Questioned why a SIM_ONLY definition was commented out in the test file list
- Noted that a preprocessor directive should use ifdef instead of ifndef for the memory access assertion section

roman012285's Responses:
The author acknowledged making changes immediately after pushing and committed to fixing the preprocessor directive, stating: "I changed it right after I made push, I will commit it when i will be near computer. I must change ifndef to ifdef also"

After implementing corrections, roman012285 requested: "fixed - Please review the changes"

Final Approval:
amichai-bd approved the revised implementation and merged the pull request.

Related Issue:
This PR links to and likely closes issue #498: "rrv_core - Add a assertion for illegal memory access region"