Add files using upload-large-folder tool
Browse filesThis view is limited to 50 files because it contains too many changes. See raw diff
- issues/AsFigo_pyslint_pr140 +37 -0
- issues/AsFigo_pyslint_pr149 +56 -0
- issues/AsFigo_pyslint_pr175 +57 -0
- issues/FPGA-MAFIA_fpga_mafia_pr465 +25 -0
- issues/HiSA-Team_Simply-V_pr52 +20 -0
- issues/HiSA-Team_Simply-V_pr92 +24 -0
- issues/Lampro-Mellon_LM-RISCV-DV_pr81 +20 -0
- issues/MiSTer-devel_Arcade-Robotron_MiSTer_pr25 +24 -0
- issues/MiSTer-devel_NES_MiSTer_pr135 +39 -0
- issues/Multimedia-Processing_Digital-Logic-Design_pr48 +50 -0
- issues/Multimedia-Processing_Digital-Logic-Design_pr50 +57 -0
- issues/Multimedia-Processing_Digital-Logic-Design_pr60 +43 -0
- issues/Wren6991_Hazard3_pr23 +21 -0
- issues/Wren6991_Hazard3_pr41 +36 -0
- issues/aolofsson_oh_pr75 +20 -0
- issues/bensampson5_libsv_pr150 +48 -0
- issues/bensampson5_libsv_pr19 +32 -0
- issues/bensampson5_libsv_pr98 +16 -0
- issues/bespoke-silicon-group_basejump_stl_pr472 +16 -0
- issues/bespoke-silicon-group_basejump_stl_pr715 +30 -0
- issues/black-parrot_black-parrot_pr947 +39 -0
- issues/black-parrot_black-parrot_pr974 +26 -0
- issues/chipsalliance_adams-bridge_pr176 +28 -0
- issues/chipsalliance_adams-bridge_pr66 +41 -0
- issues/chipsalliance_adams-bridge_pr82 +27 -0
- issues/chipsalliance_caliptra-rtl_pr921 +36 -0
- issues/hdl-util_hdmi_pr15 +37 -0
- issues/hdl-util_hdmi_pr23 +19 -0
- issues/jotego_jtcores_pr1100 +21 -0
- issues/jotego_jtcores_pr1177 +20 -0
- issues/jotego_jtcores_pr1242 +24 -0
- issues/jotego_jtcores_pr951 +23 -0
- issues/kumarrishav14_AMBA_APB_pr18 +22 -0
- issues/lowRISC_ibex_pr1839 +34 -0
- issues/lowRISC_ibex_pr1865 +43 -0
- issues/lowRISC_ibex_pr2261 +90 -0
- issues/muneeb-mbytes_pulpino__spi_master__ip_verification_pr42 +53 -0
- issues/muneeb-mbytes_pulpino__spi_master__ip_verification_pr56 +26 -0
- issues/muneeb-mbytes_pulpino__spi_master__ip_verification_pr61 +45 -0
- issues/muneeb-mbytes_pulpino__spi_master__subsystem_verification_pr28 +47 -0
- issues/olofk_serv_pr105 +38 -0
- issues/openhwgroup_cv32e40s_pr259 +32 -0
- issues/pulp-platform_apb_pr2 +22 -0
- issues/pulp-platform_apb_pr3 +20 -0
- issues/pulp-platform_apb_pr8 +35 -0
- issues/pulp-platform_axi_pr74 +25 -0
- issues/pulp-platform_axi_riscv_atomics_pr15 +52 -0
- issues/pulp-platform_axi_riscv_atomics_pr27 +32 -0
- issues/pulp-platform_axi_riscv_atomics_pr31 +37 -0
- issues/pulp-platform_carfield_pr41 +49 -0
issues/AsFigo_pyslint_pr140
ADDED
|
@@ -0,0 +1,37 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# SV: post/pre randomize return value check - COMPAT issue
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/AsFigo/pyslint/issues/139
|
| 4 |
+
|
| 5 |
+
```verilog
|
| 6 |
+
class gen_c;
|
| 7 |
+
rand bit b;
|
| 8 |
+
|
| 9 |
+
function pre_randomize();
|
| 10 |
+
endfunction
|
| 11 |
+
|
| 12 |
+
function post_randomize();
|
| 13 |
+
endfunction
|
| 14 |
+
endclass : gen_c
|
| 15 |
+
```
|
| 16 |
+
|
| 17 |
+
Above code works fine in one but not in all others.
|
| 18 |
+
|
| 19 |
+
## PR Content from GitHub
|
| 20 |
+
|
| 21 |
+
# Pull Request #140 Summary
|
| 22 |
+
|
| 23 |
+
**PR Title:** Added rule to address issue 139
|
| 24 |
+
|
| 25 |
+
**PR Description Body:**
|
| 26 |
+
The page does not display a full description body beyond the title. The only substantive comment is: "Fixes #139"
|
| 27 |
+
|
| 28 |
+
**PR Comments:**
|
| 29 |
+
- **Author: svenka3** - "Fixes #139"
|
| 30 |
+
|
| 31 |
+
**Linked Issue #139:**
|
| 32 |
+
**Title:** "SV: post/pre randomize return value check - COMPAT issue"
|
| 33 |
+
|
| 34 |
+
**Issue Body:**
|
| 35 |
+
Not provided in the extracted content.
|
| 36 |
+
|
| 37 |
+
**Status:** This PR was merged by svenka3 on November 29, 2023, into the main branch from the i139 branch.
|
issues/AsFigo_pyslint_pr149
ADDED
|
@@ -0,0 +1,56 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# DPI - checks needed inside interface context
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/AsFigo/pyslint/issues/147
|
| 4 |
+
|
| 5 |
+
DPI checks to be added for interface context.
|
| 6 |
+
|
| 7 |
+
```verilog
|
| 8 |
+
interface af_sv_if;
|
| 9 |
+
import "DPI" function int c_sum();
|
| 10 |
+
endinterface : af_sv_if
|
| 11 |
+
```
|
| 12 |
+
|
| 13 |
+
## PR Content from GitHub
|
| 14 |
+
|
| 15 |
+
# Pull Request Summary
|
| 16 |
+
|
| 17 |
+
**PR Title:** DPI enhancements
|
| 18 |
+
|
| 19 |
+
**PR Number:** #149
|
| 20 |
+
|
| 21 |
+
**Status:** Merged
|
| 22 |
+
|
| 23 |
+
**Author:** svenka3
|
| 24 |
+
|
| 25 |
+
**Merge Date:** December 1, 2023
|
| 26 |
+
|
| 27 |
+
---
|
| 28 |
+
|
| 29 |
+
## PR Description
|
| 30 |
+
|
| 31 |
+
The pull request description is minimal. The author only states: "Fixes #147 and #148"
|
| 32 |
+
|
| 33 |
+
---
|
| 34 |
+
|
| 35 |
+
## Commits
|
| 36 |
+
|
| 37 |
+
Two commits were included:
|
| 38 |
+
1. "Fixes Issue #147" (commit f340d60)
|
| 39 |
+
2. "Support for DPI inside PKG is added" (commit e15120a)
|
| 40 |
+
|
| 41 |
+
---
|
| 42 |
+
|
| 43 |
+
## Comments
|
| 44 |
+
|
| 45 |
+
**svenka3** commented on December 1, 2023:
|
| 46 |
+
"Fixes #147 and #148"
|
| 47 |
+
|
| 48 |
+
---
|
| 49 |
+
|
| 50 |
+
## Linked Issues
|
| 51 |
+
|
| 52 |
+
This PR references two issues:
|
| 53 |
+
- **Issue #147:** "DPI - checks needed inside interface context"
|
| 54 |
+
- **Issue #148:** "DPI - checks need to be performed for package scoped DPI methods"
|
| 55 |
+
|
| 56 |
+
The pull request successfully closed Issue #147. Issue #148 was also referenced and addressed through the implementation of DPI (Direct Programming Interface) support within package scoping contexts.
|
issues/AsFigo_pyslint_pr175
ADDED
|
@@ -0,0 +1,57 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# COMPAT SVA missing ;
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/AsFigo/pyslint/issues/174
|
| 4 |
+
|
| 5 |
+
```verilog
|
| 6 |
+
module m;
|
| 7 |
+
bit clk, a, b;
|
| 8 |
+
|
| 9 |
+
property p_ex;
|
| 10 |
+
@(posedge clk) a |=> b
|
| 11 |
+
endproperty : p_ex
|
| 12 |
+
|
| 13 |
+
endmodule : m
|
| 14 |
+
```
|
| 15 |
+
|
| 16 |
+
## PR Content from GitHub
|
| 17 |
+
|
| 18 |
+
# GitHub Pull Request Summary
|
| 19 |
+
|
| 20 |
+
**PR Title:** Added rule 174 - COMPAT
|
| 21 |
+
|
| 22 |
+
**PR Number:** #175
|
| 23 |
+
|
| 24 |
+
**Status:** Merged
|
| 25 |
+
|
| 26 |
+
**Author:** svenka3
|
| 27 |
+
|
| 28 |
+
**Merge Date:** December 8, 2023
|
| 29 |
+
|
| 30 |
+
---
|
| 31 |
+
|
| 32 |
+
## PR Description
|
| 33 |
+
The PR description body is not explicitly shown in the provided content beyond the title.
|
| 34 |
+
|
| 35 |
+
## Comments
|
| 36 |
+
|
| 37 |
+
**svenka3** commented:
|
| 38 |
+
> "Fixes #174"
|
| 39 |
+
|
| 40 |
+
This brief comment references the linked issue.
|
| 41 |
+
|
| 42 |
+
---
|
| 43 |
+
|
| 44 |
+
## Linked Issue
|
| 45 |
+
|
| 46 |
+
**Issue #174 Title:** "COMPAT SVA missing ;"
|
| 47 |
+
|
| 48 |
+
The issue title indicates this PR addresses a missing semicolon issue related to COMPAT SVA functionality.
|
| 49 |
+
|
| 50 |
+
---
|
| 51 |
+
|
| 52 |
+
## Additional Details
|
| 53 |
+
|
| 54 |
+
- **Commits:** 1 commit merged (09108a8)
|
| 55 |
+
- **Branch:** Merged from `i174` into `main`
|
| 56 |
+
- **Reviewers:** None listed
|
| 57 |
+
- **Assignees:** None listed
|
issues/FPGA-MAFIA_fpga_mafia_pr465
ADDED
|
@@ -0,0 +1,25 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# add HW interrupt support to core_rrv
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/FPGA-MAFIA/fpga_mafia/issues/437
|
| 4 |
+
|
| 5 |
+
The interrupt will start when one of the counters will reach a predefined value.
|
| 6 |
+
|
| 7 |
+
PR Title: fix issues we talked about csr
|
| 8 |
+
|
| 9 |
+
Description:
|
| 10 |
+
The contributor implemented an initial version that executes instructions once the timer interrupt is triggered. This approach ensures interrupts are processed when NOPs are absent, preventing loops. The implementation was tested with multiple timers using the comparison method for valid instructions. All relevant CSR updates are handled in the CSR module rather than software.
|
| 11 |
+
|
| 12 |
+
Commits (4):
|
| 13 |
+
1. Remove CSR check in ctrl and pass to CSR unit
|
| 14 |
+
2. Merge branch 'main' into core_rrv
|
| 15 |
+
3. Fix merge conflict issues
|
| 16 |
+
4. Fix timer interrupt handler
|
| 17 |
+
|
| 18 |
+
Comments:
|
| 19 |
+
roman012285 (Collaborator): "I chose to implement our initial version and execute the instruction once the timer interrupt is triggered... All the updated of relevant csrs are handled in CSR module and not in the software."
|
| 20 |
+
|
| 21 |
+
amichai-bd (Reviewer/Merger): "Great job!"
|
| 22 |
+
|
| 23 |
+
Linked Issue: #437 - "add HW interrupt support to core_rrv"
|
| 24 |
+
|
| 25 |
+
Status: Merged by amichai-bd on February 2, 2024
|
issues/HiSA-Team_Simply-V_pr52
ADDED
|
@@ -0,0 +1,20 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# [feature/core_selection] Add core selection to Make flow
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/HiSA-Team/Simply-V/issues/20
|
| 4 |
+
|
| 5 |
+
## Issue Title
|
| 6 |
+
[feature/core_selection] Add core selection to Make flow
|
| 7 |
+
|
| 8 |
+
## Issue Description
|
| 9 |
+
Add core selection to Make flow for RVM socket CORE_SELECTION parameter.
|
| 10 |
+
|
| 11 |
+
## Issue Comments
|
| 12 |
+
None visible.
|
| 13 |
+
|
| 14 |
+
## Issue Metadata
|
| 15 |
+
- Status: Closed
|
| 16 |
+
- Assignee: MaistoV
|
| 17 |
+
- Milestone: MCU release
|
| 18 |
+
|
| 19 |
+
## Linked Issues / PRs
|
| 20 |
+
- PR #52 — implementation (closed)
|
issues/HiSA-Team_Simply-V_pr92
ADDED
|
@@ -0,0 +1,24 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# [feature/cores/ibex] Integrate Ibex core as custom IP
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/HiSA-Team/Simply-V/issues/66
|
| 4 |
+
|
| 5 |
+
## Issue Title
|
| 6 |
+
[feature/cores/ibex] Integrate Ibex core as custom IP
|
| 7 |
+
|
| 8 |
+
## Issue Description
|
| 9 |
+
From https://github.com/lowRISC/ibex.
|
| 10 |
+
|
| 11 |
+
Issues:
|
| 12 |
+
- which release?
|
| 13 |
+
- which DTM to use? from PULP or ibex-demo-system?
|
| 14 |
+
|
| 15 |
+
## Issue Comments
|
| 16 |
+
None visible.
|
| 17 |
+
|
| 18 |
+
## Issue Metadata
|
| 19 |
+
- Status: Closed (via PR #92)
|
| 20 |
+
- Opened by: MaistoV on March 11, 2025
|
| 21 |
+
- Assignees: Granp4sso, MaistoV
|
| 22 |
+
|
| 23 |
+
## Linked Issues / PRs
|
| 24 |
+
- PR #92 — appears to be the resolution implementation
|
issues/Lampro-Mellon_LM-RISCV-DV_pr81
ADDED
|
@@ -0,0 +1,20 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Enable Verilator in the RTL Simulation Flow for SweRV integration
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/Lampro-Mellon/LM-RISCV-DV/issues/69
|
| 4 |
+
|
| 5 |
+
|
| 6 |
+
## Fetched Issue/PR Details
|
| 7 |
+
|
| 8 |
+
Title: Enable Verilator in the RTL Simulation Flow for SweRV integration (#69)
|
| 9 |
+
|
| 10 |
+
Description: No description was provided in the original issue.
|
| 11 |
+
|
| 12 |
+
Status: Closed (resolved via PR #81)
|
| 13 |
+
Assignee: amnafayyaz28
|
| 14 |
+
Label: enhancement
|
| 15 |
+
Reporter: haroon-shafique
|
| 16 |
+
Opened: January 7, 2021
|
| 17 |
+
|
| 18 |
+
Comments: No comments, reactions, or additional context were visible on the page.
|
| 19 |
+
|
| 20 |
+
Linked Issues: Resolving PR #81. The issue requests integration of Verilator (an open-source RTL simulator) into the RTL simulation workflow for SweRV core integration within the LM-RISCV-DV project.
|
issues/MiSTer-devel_Arcade-Robotron_MiSTer_pr25
ADDED
|
@@ -0,0 +1,24 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Core is outputting at 296 x 243...
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/MiSTer-devel/Arcade-Robotron_MiSTer/issues/24
|
| 4 |
+
|
| 5 |
+
...instead of 292 x 240 and as such doesn't seem to want to scale to 720p.
|
| 6 |
+
|
| 7 |
+
## Fetched Issue/PR Details
|
| 8 |
+
|
| 9 |
+
Title: Core is outputting at 296 x 243... (#24)
|
| 10 |
+
|
| 11 |
+
Description: The core outputs a resolution of 296 x 243 pixels instead of the expected 292 x 240, which prevents proper scaling to 720p.
|
| 12 |
+
|
| 13 |
+
Repository: MiSTer-devel/Arcade-Robotron_MiSTer
|
| 14 |
+
Author: dazzer69
|
| 15 |
+
Opened: September 27, 2021
|
| 16 |
+
Status: Closed (linked to PR #25)
|
| 17 |
+
|
| 18 |
+
Additional Details:
|
| 19 |
+
- No assignees or labels
|
| 20 |
+
- No open branches or pull requests associated
|
| 21 |
+
|
| 22 |
+
Comments: No comments visible.
|
| 23 |
+
|
| 24 |
+
Linked Issues: Resolving PR #25.
|
issues/MiSTer-devel_NES_MiSTer_pr135
ADDED
|
@@ -0,0 +1,39 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Indiana Jones 3 glitchy title screen
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/MiSTer-devel/NES_MiSTer/issues/129
|
| 4 |
+
|
| 5 |
+
Indiana Jones and The Last Crusade (Taito) shows some flickering lines that shouldn't be there in the title screen.
|
| 6 |
+
|
| 7 |
+
---
|
| 8 |
+
|
| 9 |
+
## Pull Request
|
| 10 |
+
|
| 11 |
+
**PR Title:** Timing fixes
|
| 12 |
+
|
| 13 |
+
**PR Number:** #135
|
| 14 |
+
|
| 15 |
+
**Status:** Merged on Sep 15, 2019
|
| 16 |
+
|
| 17 |
+
### Description
|
| 18 |
+
|
| 19 |
+
Kitrinx's initial comment detailed the changes:
|
| 20 |
+
|
| 21 |
+
> "Several timing related fixes. Passes 3 more tests. Resolves #129 (Indiana Jones) Resolves flickering line on Zelda 2 title screen Resolves colored line on Micro Machines title screen"
|
| 22 |
+
|
| 23 |
+
The PR also addressed preliminary support for Mapper 4, submacker 3 (Acclaim's MMC3) for games including Mickey's Safari in Letterland and Incredible Crash Dummies. Additionally, it fixed SNAC controller swap issues and cleaned up compiler warnings.
|
| 24 |
+
|
| 25 |
+
### Comments
|
| 26 |
+
|
| 27 |
+
**MP2E** responded positively: "Outstanding work"
|
| 28 |
+
|
| 29 |
+
**Kitrinx** added: The update also resolved SNAC controller swap issues and cleaned up several warnings.
|
| 30 |
+
|
| 31 |
+
**yxkalle** expressed gratitude: "Thank you very much"
|
| 32 |
+
|
| 33 |
+
### Linked Issues
|
| 34 |
+
|
| 35 |
+
The PR resolved **#129**: "Indiana Jones 3 glitchy title screen"
|
| 36 |
+
|
| 37 |
+
### Participants
|
| 38 |
+
|
| 39 |
+
Kitrinx (author), sorgelig (merged), MP2E, yxkalle
|
issues/Multimedia-Processing_Digital-Logic-Design_pr48
ADDED
|
@@ -0,0 +1,50 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# 6-3 多工器與解多工器的實習
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/Multimedia-Processing/Digital-Logic-Design/issues/44
|
| 4 |
+
|
| 5 |
+
1. 明瞭多工器的原理與電路設計的方法
|
| 6 |
+
2. 明瞭解多工器的原理與電路設計的方法
|
| 7 |
+
3. 學習解多工器與解碼器的互用方式
|
| 8 |
+
4. 學習直接套用制式IC完成所需
|
| 9 |
+
|
| 10 |
+
---
|
| 11 |
+
|
| 12 |
+
## Pull Request
|
| 13 |
+
|
| 14 |
+
**PR Title:** 47 verilog hdl practice ch4
|
| 15 |
+
|
| 16 |
+
**PR Number:** #48
|
| 17 |
+
|
| 18 |
+
**Status:** Merged on November 19, 2020
|
| 19 |
+
|
| 20 |
+
**Author:** timmy61109
|
| 21 |
+
|
| 22 |
+
**Target:** master branch
|
| 23 |
+
|
| 24 |
+
**Source Branch:** 47-VerilogHDL-Practice-CH4
|
| 25 |
+
|
| 26 |
+
### Description
|
| 27 |
+
|
| 28 |
+
No description was provided by the author.
|
| 29 |
+
|
| 30 |
+
### Commits (19 total)
|
| 31 |
+
|
| 32 |
+
The pull request contained 19 commits with messages in Traditional Chinese, including:
|
| 33 |
+
|
| 34 |
+
- Updates to `.gitignore` for Vivado-generated directories
|
| 35 |
+
- Implementation of 2-to-1 and 4-to-2 multiplexers
|
| 36 |
+
- Completion of a 1-bit full adder with gate-level descriptions
|
| 37 |
+
- Four work items related to Chapter 6, Section 3
|
| 38 |
+
- 4-to-1 multiplexer implementation
|
| 39 |
+
- Addition of execution scripts
|
| 40 |
+
|
| 41 |
+
### Linked Issue
|
| 42 |
+
|
| 43 |
+
This PR closes issue #44: "6-3 多工器與解多工器的實習" (Chapter 6-3 Multiplexer and Demultiplexer Practice)
|
| 44 |
+
|
| 45 |
+
### Metadata
|
| 46 |
+
|
| 47 |
+
- Assigned to: JulianHsia, timmy61109, JulianXia-2020
|
| 48 |
+
- Labels: documentation, enhancement
|
| 49 |
+
- Milestone: Chapter 6
|
| 50 |
+
- Participants: 3 users
|
issues/Multimedia-Processing_Digital-Logic-Design_pr50
ADDED
|
@@ -0,0 +1,57 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Verilog硬體描述語言實務 第二版 Chapter4
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/Multimedia-Processing/Digital-Logic-Design/issues/47
|
| 4 |
+
|
| 5 |
+
- 4-1 基本邏輯閘
|
| 6 |
+
- 4-2 實例說明
|
| 7 |
+
|
| 8 |
+
練習題
|
| 9 |
+
|
| 10 |
+
- [x] 1
|
| 11 |
+
- [x] 2
|
| 12 |
+
|
| 13 |
+
---
|
| 14 |
+
|
| 15 |
+
## Pull Request
|
| 16 |
+
|
| 17 |
+
**PR Title:** 47 verilog hdl practice ch4
|
| 18 |
+
|
| 19 |
+
**PR Number:** #50
|
| 20 |
+
|
| 21 |
+
**Status:** Merged on November 27, 2020
|
| 22 |
+
|
| 23 |
+
**Author:** timmy61109
|
| 24 |
+
|
| 25 |
+
### Description
|
| 26 |
+
|
| 27 |
+
No description was provided for this pull request.
|
| 28 |
+
|
| 29 |
+
### Commits
|
| 30 |
+
|
| 31 |
+
The PR contained three commits:
|
| 32 |
+
1. "如果採用,此提交將新增練習題第一題" (adds practice problem 1)
|
| 33 |
+
2. "如果採用,此提交將完成第四章練習題第二題" (completes Chapter 4 practice problem 2)
|
| 34 |
+
3. "如果採用,此提交將新增執行的腳本" (adds execution scripts)
|
| 35 |
+
|
| 36 |
+
### Labels
|
| 37 |
+
|
| 38 |
+
- Documentation (improvements/additions to documentation)
|
| 39 |
+
- Enhancement (new feature or request)
|
| 40 |
+
|
| 41 |
+
### Assignees
|
| 42 |
+
|
| 43 |
+
- JulianHsia
|
| 44 |
+
- timmy61109
|
| 45 |
+
- JulianXia-2020
|
| 46 |
+
|
| 47 |
+
### Linked Issue
|
| 48 |
+
|
| 49 |
+
"Verilog硬體描述語言實務 第二版 Chapter4" (#47)
|
| 50 |
+
|
| 51 |
+
### Milestone
|
| 52 |
+
|
| 53 |
+
Verilog硬體描述語言實務 第二版
|
| 54 |
+
|
| 55 |
+
### Comments
|
| 56 |
+
|
| 57 |
+
No substantive comments were recorded in the conversation thread.
|
issues/Multimedia-Processing_Digital-Logic-Design_pr60
ADDED
|
@@ -0,0 +1,43 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Verilog硬體描述語言實務 第二版 Chapter5 資料留層次之敘述
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/Multimedia-Processing/Digital-Logic-Design/issues/52
|
| 4 |
+
|
| 5 |
+
- assign連續指定
|
| 6 |
+
- 運算子
|
| 7 |
+
- 綜合範例
|
| 8 |
+
|
| 9 |
+
---
|
| 10 |
+
|
| 11 |
+
## Pull Request
|
| 12 |
+
|
| 13 |
+
**PR Title:** Verilog硬體描述語言實務 第二版 Chapter5 資料留層次之敘述 (#60)
|
| 14 |
+
|
| 15 |
+
**PR Number:** #60
|
| 16 |
+
|
| 17 |
+
**Status:** Merged on December 17, 2020
|
| 18 |
+
|
| 19 |
+
### Description
|
| 20 |
+
|
| 21 |
+
The pull request introduces content for Chapter 5 of a Verilog hardware description language textbook (second edition), focusing on dataflow-level descriptions. The contributor listed three main topics:
|
| 22 |
+
|
| 23 |
+
- assign連續指定 (continuous assignment)
|
| 24 |
+
- 運算子 (operators)
|
| 25 |
+
- 綜合範例 (synthesis examples)
|
| 26 |
+
|
| 27 |
+
### Key Details
|
| 28 |
+
|
| 29 |
+
**Author:** timmy61109
|
| 30 |
+
|
| 31 |
+
**Commits:** 6 commits added between December 3-17, 2020
|
| 32 |
+
|
| 33 |
+
**Linked Issue:** #52 - "Verilog硬體描述語言實務 第二版 Chapter5 資料留層次之敘述"
|
| 34 |
+
|
| 35 |
+
**Labels:** documentation, enhancement
|
| 36 |
+
|
| 37 |
+
**Milestone:** Verilog硬體描述語言實務 第二版
|
| 38 |
+
|
| 39 |
+
### Notable Elements
|
| 40 |
+
|
| 41 |
+
The pull request included two example modules: "vector" (demonstrating vector access operations) and "op" (demonstrating operator calculations). Subsequent commits through 2022 expanded the content with arithmetic micro-operations, test files, presentations, and circuit diagrams.
|
| 42 |
+
|
| 43 |
+
**Reviewers Requested:** JulianHsia, JulianXia-2020
|
issues/Wren6991_Hazard3_pr23
ADDED
|
@@ -0,0 +1,21 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Fix abstract command using wrong register when initiated by abstractauto
|
| 2 |
+
|
| 3 |
+
Instance: Wren6991_Hazard3_pr23
|
| 4 |
+
Source: https://github.com/Wren6991/Hazard3/pull/23
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: Wren6991/Hazard3
|
| 7 |
+
Pull request: #23
|
| 8 |
+
Author: Wren6991
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: stable
|
| 11 |
+
Head branch: fix-dm-abstractauto-regno
|
| 12 |
+
Created: 2024-10-12T18:58:43Z
|
| 13 |
+
Updated: 2024-10-12T22:57:18Z
|
| 14 |
+
Closed: 2024-10-12T19:03:45Z
|
| 15 |
+
Merged: 2024-10-12T19:03:45Z
|
| 16 |
+
|
| 17 |
+
This affects memory downloads from the debugger when System Bus Access is not enabled or not configured.
|
| 18 |
+
|
| 19 |
+
This bug was introduced in https://github.com/Wren6991/Hazard3/commit/78a5cb98ea5d184c7b8bf31249ce8ac69e4abf68
|
| 20 |
+
|
| 21 |
+
Releasing as a point fix due to severity and due to the fix being localised to the Debug Module.
|
issues/Wren6991_Hazard3_pr41
ADDED
|
@@ -0,0 +1,36 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Release v1.1.1 to stable
|
| 2 |
+
|
| 3 |
+
Instance: Wren6991_Hazard3_pr41
|
| 4 |
+
Source: https://github.com/Wren6991/Hazard3/pull/41
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: Wren6991/Hazard3
|
| 7 |
+
Pull request: #41
|
| 8 |
+
Author: Wren6991
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: stable
|
| 11 |
+
Head branch: develop
|
| 12 |
+
Created: 2026-03-12T18:19:01Z
|
| 13 |
+
Updated: 2026-03-12T18:28:21Z
|
| 14 |
+
Closed: 2026-03-12T18:28:21Z
|
| 15 |
+
Merged: 2026-03-12T18:28:21Z
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
Release v1.1.1 to stable
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
No description was provided for this pull request. The PR is a release-merge of `develop` into `stable` containing 8 commits that constitute Hazard3 v1.1.1:
|
| 22 |
+
|
| 23 |
+
1. Update mimpid: 1.2 prerelease
|
| 24 |
+
2. Fix repeated transfer on APB async bridge when instantiated separately to the JTAG-DTM
|
| 25 |
+
3. Don't report failed exclusive writes as faults in `rvfi_bus_observer`; latch `rvfi_intr` signal; fix exclusives hookup in riscv-formal tb
|
| 26 |
+
4. Fix uninitialised variable in `wfi_loop` tests
|
| 27 |
+
5. Fix non-synthesisable statement in `hazard3_rvfi_monitor` when `HAZARD3_RVFI_STANDALONE` is defined
|
| 28 |
+
6. Fix RVFI monitor reporting memory write for exclusive store that fails in data phase
|
| 29 |
+
7. Fix: hardware breakpoint on CSR-writing instruction does not inhibit CSR write
|
| 30 |
+
8. Set `mimpid` version to 1.1.1; update release notes in asciidoc
|
| 31 |
+
|
| 32 |
+
## PR Comments
|
| 33 |
+
No conversation comments were posted on the PR. No assignees, labels, milestones, or external reviewers.
|
| 34 |
+
|
| 35 |
+
## Linked Issues
|
| 36 |
+
No linked issues are referenced in this pull request.
|
issues/aolofsson_oh_pr75
ADDED
|
@@ -0,0 +1,20 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Gpio fpga project
|
| 2 |
+
|
| 3 |
+
Instance: aolofsson_oh_pr75
|
| 4 |
+
Source: https://github.com/aolofsson/oh/pull/75
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: aolofsson/oh
|
| 7 |
+
Pull request: #75
|
| 8 |
+
Author: olajep
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: gpio-fpga-project
|
| 12 |
+
Created: 2016-05-03T15:49:33Z
|
| 13 |
+
Updated: 2016-05-03T17:35:54Z
|
| 14 |
+
Closed: 2016-05-03T17:35:54Z
|
| 15 |
+
Merged: 2016-05-03T17:35:54Z
|
| 16 |
+
|
| 17 |
+
Reading and writing from Porcupine pins now works.
|
| 18 |
+
|
| 19 |
+
There's something wrong with edge-triggered interrupts (what you can get via sysfs).
|
| 20 |
+
Loks like clearing the interrupt (in the interrupt handler) will create a new edge and a new interrupt and ... spam the system with interrupts. Will look into that next.
|
issues/bensampson5_libsv_pr150
ADDED
|
@@ -0,0 +1,48 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Fix reconvergence issue with synchronizer
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/bensampson5/libsv/issues/149
|
| 4 |
+
|
| 5 |
+
Synchronizer can't handle multibit data so update to be just a single bit synchronizer
|
| 6 |
+
|
| 7 |
+
## PR Content from GitHub
|
| 8 |
+
|
| 9 |
+
# Pull Request Summary
|
| 10 |
+
|
| 11 |
+
**PR Title:** Fix reconvergence issue in synchronizer
|
| 12 |
+
|
| 13 |
+
**PR Number:** #150
|
| 14 |
+
|
| 15 |
+
**Repository:** bensampson5/libsv
|
| 16 |
+
|
| 17 |
+
**Status:** Merged (February 7, 2022)
|
| 18 |
+
|
| 19 |
+
---
|
| 20 |
+
|
| 21 |
+
## PR Description
|
| 22 |
+
The PR description body was not fully visible in the provided content. The only explicit reference states: "Closes #149"
|
| 23 |
+
|
| 24 |
+
---
|
| 25 |
+
|
| 26 |
+
## Comments
|
| 27 |
+
|
| 28 |
+
**Author:** bensampson5
|
| 29 |
+
|
| 30 |
+
Comment text: "Closes #149"
|
| 31 |
+
|
| 32 |
+
---
|
| 33 |
+
|
| 34 |
+
## Linked Issue
|
| 35 |
+
|
| 36 |
+
**Issue #149 Title:** Fix reconvergence issue with synchronizer
|
| 37 |
+
|
| 38 |
+
**Issue Description:** The full issue body was not included in the extracted content, though the PR references it as the issue being resolved.
|
| 39 |
+
|
| 40 |
+
---
|
| 41 |
+
|
| 42 |
+
## Merge Information
|
| 43 |
+
|
| 44 |
+
- **Merged by:** bensampson5
|
| 45 |
+
- **Merge commit:** 989a51a
|
| 46 |
+
- **Source branch:** issue-149-Fix_reconvergence_issue_with_synchronizer
|
| 47 |
+
- **Target branch:** main
|
| 48 |
+
- **Commits included:** 1
|
issues/bensampson5_libsv_pr19
ADDED
|
@@ -0,0 +1,32 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Write Verilator testbench for counter
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/bensampson5/libsv/issues/7
|
| 4 |
+
|
| 5 |
+
|
| 6 |
+
## PR Content from GitHub
|
| 7 |
+
|
| 8 |
+
# Pull Request Summary
|
| 9 |
+
|
| 10 |
+
**PR Title:** Docker try catch2 #19
|
| 11 |
+
|
| 12 |
+
**PR Status:** Merged (December 29, 2020)
|
| 13 |
+
|
| 14 |
+
**PR Description Body:**
|
| 15 |
+
The description content failed to load properly in the provided page content, showing "Uh oh! There was an error while loading. Please reload this page." However, the PR closing statement indicates: "Closes #7" and "Closes #11"
|
| 16 |
+
|
| 17 |
+
**PR Comments:**
|
| 18 |
+
No readable comment content was successfully extracted from the conversation section due to loading errors displayed on the page.
|
| 19 |
+
|
| 20 |
+
**Linked Issues:**
|
| 21 |
+
1. **Issue #11:** "See if catch2 can be leveraged for unit testing IP"
|
| 22 |
+
2. **Issue #7:** "Write Verilator testbench for counter"
|
| 23 |
+
|
| 24 |
+
**Commits Included (6 total):**
|
| 25 |
+
- Add catch2 install to Dockerfile
|
| 26 |
+
- Integrate catch2
|
| 27 |
+
- Write unit test for counter
|
| 28 |
+
- Added SRC_DIR to CMake
|
| 29 |
+
- Add ninja-build install to Dockerfile
|
| 30 |
+
- Update readme and format counter.sv
|
| 31 |
+
|
| 32 |
+
**Author:** bensampson5
|
issues/bensampson5_libsv_pr98
ADDED
|
@@ -0,0 +1,16 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# 8b/10b encoder
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/bensampson5/libsv/issues/97
|
| 4 |
+
|
| 5 |
+
Implement 8b/10b encoder
|
| 6 |
+
|
| 7 |
+
https://en.wikipedia.org/wiki/8b/10b_encoding
|
| 8 |
+
|
| 9 |
+
## Linked Issue Content from GitHub
|
| 10 |
+
|
| 11 |
+
**Issue #97: 8b/10b encoder**
|
| 12 |
+
|
| 13 |
+
- Body: "Implement 8b/10b encoder. https://en.wikipedia.org/wiki/8b/10b_encoding"
|
| 14 |
+
- Status: Closed (related PR #98)
|
| 15 |
+
- Assignee: bensampson5, Label: enhancement, Created November 23, 2021
|
| 16 |
+
- Comments: None.
|
issues/bespoke-silicon-group_basejump_stl_pr472
ADDED
|
@@ -0,0 +1,16 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Potential bug in hardened fifo module
|
| 2 |
+
|
| 3 |
+
The hardened fifo module contains a variable `read_write_same_addr_n`, which is currently assigned as `wptr_r == rptr_r`. The comment for this variable mentions that it should be 1 when the fifo is empty, but the condition is true for both empty and full fifo conditions. The line in question is given below:
|
| 4 |
+
|
| 5 |
+
https://github.com/bespoke-silicon-group/basejump_stl/blob/4cfaeb454a7278f7d13eb766dad07ce34fefcdea/bsg_dataflow/bsg_fifo_1r1w_small_hardened.v#L118
|
| 6 |
+
|
| 7 |
+
If this variable is 1 when the fifo is full, it prevents the memory read as in https://github.com/bespoke-silicon-group/basejump_stl/blob/4cfaeb454a7278f7d13eb766dad07ce34fefcdea/bsg_dataflow/bsg_fifo_1r1w_small_hardened.v#L95
|
| 8 |
+
The assignment can instead be `assign read_write_same_addr_n = empty`.
|
| 9 |
+
|
| 10 |
+
## Linked Issue Content from GitHub
|
| 11 |
+
|
| 12 |
+
**Issue #465: Potential bug in hardened fifo module**
|
| 13 |
+
|
| 14 |
+
- Body: `read_write_same_addr_n = wptr_r == rptr_r` is true for both empty AND full conditions, but the comment says it should be 1 only when empty. When fifo is full, this prevents memory read at line 95 (`r_v_i (~read_write_same_addr_n)`). Suggested fix: `assign read_write_same_addr_n = empty`.
|
| 15 |
+
- Author: Shashank-Vijay, Opened July 19, 2021. Status: Closed (resolved via PR #472). Label: bug.
|
| 16 |
+
- Comments: None.
|
issues/bespoke-silicon-group_basejump_stl_pr715
ADDED
|
@@ -0,0 +1,30 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Fix ipoly for bank 4 and 8
|
| 2 |
+
|
| 3 |
+
Instance: bespoke-silicon-group_basejump_stl_pr715
|
| 4 |
+
Source: https://github.com/bespoke-silicon-group/basejump_stl/pull/715
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: bespoke-silicon-group/basejump_stl
|
| 7 |
+
Pull request: #715
|
| 8 |
+
Author: tommydcjung
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: hotfix_20250201
|
| 12 |
+
Created: 2025-02-01T13:23:29Z
|
| 13 |
+
Updated: 2025-02-02T00:00:51Z
|
| 14 |
+
Closed: 2025-02-02T00:00:51Z
|
| 15 |
+
Merged: 2025-02-02T00:00:51Z
|
| 16 |
+
|
| 17 |
+
PR Title: Fix ipoly for bank 4 and 8
|
| 18 |
+
|
| 19 |
+
PR Description:
|
| 20 |
+
(No description provided.)
|
| 21 |
+
|
| 22 |
+
PR Comments:
|
| 23 |
+
- tommydcjung (Feb 1, 2025, 13:23): Requested review from gaozihou
|
| 24 |
+
- gaozihou (Feb 1, 2025): "LGTM, simple typo fix" - Approved the changes
|
| 25 |
+
|
| 26 |
+
Status: Merged by gaozihou into master on Feb 2, 2025 (commit 5a8a602).
|
| 27 |
+
|
| 28 |
+
Linked Issues: None explicitly mentioned.
|
| 29 |
+
|
| 30 |
+
Additional Context: The PR contains a single commit (a6c328e) with the message "fix ipoly" and was characterized as a straightforward typo correction.
|
issues/black-parrot_black-parrot_pr947
ADDED
|
@@ -0,0 +1,39 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
PR Title: fix LCE uncached store overflow - #945
|
| 2 |
+
|
| 3 |
+
PR Description:
|
| 4 |
+
Summary: This PR adjusts the cache request valid register in the LCE Request module and tweaks credit counting to prevent overwriting and dropping of uncached store requests.
|
| 5 |
+
|
| 6 |
+
Issue Fixed: Fixes #945
|
| 7 |
+
|
| 8 |
+
Area: LCE Request
|
| 9 |
+
|
| 10 |
+
Reasoning: Functional bug fix
|
| 11 |
+
|
| 12 |
+
Additional Changes Required: None
|
| 13 |
+
|
| 14 |
+
Verification: A newly added `mc_uc_store` test in bp-tests exposes this bug. Testing revealed that "~25% of stores were dropped in a sequence of 100 consecutive stores" without the fix. With the fix applied, all stores are accounted for. A debug check was added to catch recurrence.
|
| 15 |
+
|
| 16 |
+
PR Comments:
|
| 17 |
+
- muwyse (Oct 13, 2021): "Thanks for contributing to BlackParrot! Check out the CONTRIBUTING guide, if this is your first time."
|
| 18 |
+
- dpetrisko (Oct 13, 2021): "Thanks, great!"
|
| 19 |
+
|
| 20 |
+
Linked Issue #945: "Potential uncached store drops in LCE"
|
| 21 |
+
|
| 22 |
+
Original local content (issue context):
|
| 23 |
+
Potential uncached store drops in LCE #945
|
| 24 |
+
|
| 25 |
+
black-parrot/bp_me/src/v/lce/bp_lce_req.sv
|
| 26 |
+
|
| 27 |
+
Line 223 in b095d30
|
| 28 |
+
|
| 29 |
+
// TODO: This could drop uncached stores, if we accept but lce is not ready
|
| 30 |
+
This should be handled as in https://github.com/black-parrot/black-parrot/blob/master/bp_me/src/v/cce/bp_uce.sv#L599. where the request is not accepted if it cannot go on the network (or if there is no currently pending request)
|
| 31 |
+
|
| 32 |
+
I thought the cache_req_yumi_o signal accounted for this:
|
| 33 |
+
|
| 34 |
+
black-parrot/bp_me/src/v/lce/bp_lce_req.sv
|
| 35 |
+
|
| 36 |
+
Line 237 in b095d30
|
| 37 |
+
|
| 38 |
+
cache_req_yumi_o = cache_req_v_i
|
| 39 |
+
Namely, the first part of the && conditions is (~cache_req_v_r | lce_req_v_o), which will block a new request from being accepted from the cache if we already have a valid request and it is not sending this cycle.
|
issues/black-parrot_black-parrot_pr974
ADDED
|
@@ -0,0 +1,26 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
PR Title: Fix inferred latches
|
| 2 |
+
|
| 3 |
+
PR Description:
|
| 4 |
+
The pull request removed inferred latches from `bp_me_axil_master` and `bp_me_axil_client` components. The issue was that `state_n` lacked a default value, causing it to become a latch unintentionally.
|
| 5 |
+
|
| 6 |
+
Area Affected: AXI master and client subcomponents
|
| 7 |
+
|
| 8 |
+
Linked Issue: Fixes #972
|
| 9 |
+
|
| 10 |
+
PR Activity:
|
| 11 |
+
- Self-assigned: dpetrisko (Dec 1, 2021)
|
| 12 |
+
- Label added: bug
|
| 13 |
+
- Merged commit: 7f9a1e2 (Dec 14, 2021)
|
| 14 |
+
- Branch deleted: dev_fix_axilatch
|
| 15 |
+
|
| 16 |
+
Status: Merged on Dec 14, 2021 by dpetrisko.
|
| 17 |
+
|
| 18 |
+
Linked Issue #972 body:
|
| 19 |
+
I'm using:
|
| 20 |
+
Master branch / dd2d845
|
| 21 |
+
|
| 22 |
+
Area
|
| 23 |
+
The 'state_n' variables in bp_me_axil_master and client will be inferred into latches due to incomplete cases.
|
| 24 |
+
|
| 25 |
+
https://github.com/black-parrot/black-parrot/blob/master/bp_me/src/v/network/bp_me_axil_master.sv#L68
|
| 26 |
+
https://github.com/black-parrot/black-parrot/blob/master/bp_me/src/v/network/bp_me_axil_client.sv#L73
|
issues/chipsalliance_adams-bridge_pr176
ADDED
|
@@ -0,0 +1,28 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
PR Title: [RTL][TB] Fix issues in compress, decompress, and input checks
|
| 2 |
+
|
| 3 |
+
PR Description:
|
| 4 |
+
The PR addresses four GitHub issues (165, 167, 168, 169) by implementing several fixes:
|
| 5 |
+
- Input validation for encapsulation keys (each coefficient must be < MLKEM Q)
|
| 6 |
+
- Input validation for decapsulation keys (encapsulation portion and hash verification)
|
| 7 |
+
- Reset of decompress write address after completion
|
| 8 |
+
- Proper timing of done signal in compress operation after all pipeline stages empty
|
| 9 |
+
- Random test cases for both input checks
|
| 10 |
+
|
| 11 |
+
Commits (10 total):
|
| 12 |
+
The pull request includes commits addressing: decompress write address clearing, done signal timing, sequencer state renaming with ABR prefix, flop coding fixes, decompression logic corrections, error status implementation, test cases for encap/decap input errors, and error state persistence.
|
| 13 |
+
|
| 14 |
+
Author: Nitsirks
|
| 15 |
+
Reviewer & Merger: mojtaba-bisheh (approved July 30, 2025)
|
| 16 |
+
|
| 17 |
+
Linked Issues Closed:
|
| 18 |
+
- #165: Compression block done signal assertion timing
|
| 19 |
+
- #167: Second decompression raising done prematurely
|
| 20 |
+
- #168: Decaps flow missing input check
|
| 21 |
+
- #169: Encaps flow missing input check
|
| 22 |
+
|
| 23 |
+
Linked Issue #165 body:
|
| 24 |
+
# mlkem: compression block done signal asserts before tx end
|
| 25 |
+
|
| 26 |
+
- Source URL: https://github.com/chipsalliance/adams-bridge/issues/165
|
| 27 |
+
|
| 28 |
+
In the compression when the last chunk of data being written to the memory the read done is asserted as the last rd is done but data arrives next cycle and buffer_valid_f to be set in next clock cycle. This would set the done and api write would happen in next clock cycle. But if the compress mode toggles in this cycle then the api wr isn't triggered and this causes the loss of data.
|
issues/chipsalliance_adams-bridge_pr66
ADDED
|
@@ -0,0 +1,41 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# [Security question] Extracting HW-bound keys of Caliptra
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/chipsalliance/adams-bridge/issues/48
|
| 4 |
+
|
| 5 |
+
Reference commit: 46d8b6e9cfd0020d485012cf261a21278a5e8671
|
| 6 |
+
Related SV files: mldsa_ctrl.sv
|
| 7 |
+
|
| 8 |
+
### High-level summary
|
| 9 |
+
|
| 10 |
+
If I understand correctly, when integrated into Caliptra, one of the security properties ABR wants to preserve is the secrecy of HW-bound keys (i.e. the seed originating from Key Vault IP) against Caliptra SW. In other words, ABR wants to make sure that no logical path is introduced to Caliptra with ABR that SW can exploit to extract HW-bound secrets. That should also include the intermediate secret values appearing in ML-DSA algorithms that give an attacker the signing capabilities. Such example values would be s_1, s_2 vectors, which are also part of the secret key.
|
| 11 |
+
|
| 12 |
+
I reach to this security goal assumption from the fact that there is a dedicated Key Vault IP in Caliptra and that the ABR spec says "If seed comes from key vault, this register will not contain the private key to avoid exposing secret assets to software." (Section 1.10).
|
| 13 |
+
|
| 14 |
+
I am thinking about the following scenario, and my question is whether the HW-bound secret can be leaked. In particular, I am thinking about leaking s_1 and s_2 values through SW interactions (or simply the signing key as defined in ML-DSA).
|
| 15 |
+
|
| 16 |
+
If SW is compromised, I suspect it can do the following to extract the secret signing key (originating from Key Vault IP) from ABR:
|
| 17 |
+
|
| 18 |
+
1. SW loads the seed value from Key Vault (by configuring `mldsa_kv_rd_seed_ctrl` register).
|
| 19 |
+
2. SW starts the KeyGen operation and waits until the operation completes.
|
| 20 |
+
3. In particular, SW does not run zeroize command.
|
| 21 |
+
4. SW reads PRIVKEY_OUT register to extract HW-bound signing key.
|
| 22 |
+
|
| 23 |
+
### Low-level details
|
| 24 |
+
|
| 25 |
+
In the following line:
|
| 26 |
+
|
| 27 |
+
https://github.com/chipsalliance/adams-bridge/blob/46d8b6e9cfd0020d485012cf261a21278a5e8671/src/mldsa_top/rtl/mldsa_ctrl.sv#L585
|
| 28 |
+
|
| 29 |
+
it seems to me that this line disables reading PRIVKEY_OUT register in two cases:
|
| 30 |
+
|
| 31 |
+
* In the middle of the KeyGen operation (which is good),
|
| 32 |
+
* when KeyGen is completed but the seed is coming from KeyVault. So I interpret this as an attempt to prevent SW from reading these values at the end of the KeyGen operation (`mldsa_privkey_lock` signal). This part does not seem right to me.
|
| 33 |
+
|
| 34 |
+
My understanding is that `mldsa_privkey_lock` goes down few clock cycles after KeyGen is completed. I trace this signal to `mldsa_valid_reg` in RTL eventually, if I am not mistaken. I think this signal goes down after few clock cycles KeyGen operation is completed:
|
| 35 |
+
https://github.com/chipsalliance/adams-bridge/blob/46d8b6e9cfd0020d485012cf261a21278a5e8671/src/mldsa_top/rtl/mldsa_ctrl.sv#L187
|
| 36 |
+
|
| 37 |
+
### Question
|
| 38 |
+
|
| 39 |
+
I am wondering if SW can extract HW-bound ML-DSA signing key by simply running KeyGen and reading PRIVKEY_OUT register.
|
| 40 |
+
|
| 41 |
+
@mojtaba-bisheh @ekarabu
|
issues/chipsalliance_adams-bridge_pr82
ADDED
|
@@ -0,0 +1,27 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Update directed KATs with pure MLDSA
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/chipsalliance/adams-bridge/issues/60
|
| 4 |
+
|
| 5 |
+
PR Title: updated KATs
|
| 6 |
+
Status: Merged on January 30, 2025
|
| 7 |
+
|
| 8 |
+
Description:
|
| 9 |
+
The PR description provided only states: "Updated KAT vectors"
|
| 10 |
+
|
| 11 |
+
Commits:
|
| 12 |
+
1. 9c6c65b - "updated KATs"
|
| 13 |
+
2. 1119aa7 - "MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/ekarabulut/KAT_uvm_update' with updated timestamp and hash after successful run"
|
| 14 |
+
|
| 15 |
+
Comments:
|
| 16 |
+
ekarabu (Jan 29, 2025): "Updated KAT vectors"
|
| 17 |
+
Copilot AI (Jan 30, 2025): Could not review the pull request. Five files with unsupported languages were present, including SystemVerilog sequence files and workflow metadata files.
|
| 18 |
+
mojtaba-bisheh (Jan 30, 2025): Approved the changes
|
| 19 |
+
|
| 20 |
+
Linked Issues:
|
| 21 |
+
- #60 - "Update directed KATs with pure MLDSA" (closed by this PR)
|
| 22 |
+
|
| 23 |
+
Reviewers:
|
| 24 |
+
- mojtaba-bisheh: Approved
|
| 25 |
+
- Nitsirks: Awaiting review
|
| 26 |
+
- upadhyayulakiran: Awaiting review
|
| 27 |
+
- Copilot: Reviewed (unable to process files)
|
issues/chipsalliance_caliptra-rtl_pr921
ADDED
|
@@ -0,0 +1,36 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# ECC pubkey check in ECDH
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/chipsalliance/caliptra-rtl/issues/917
|
| 4 |
+
|
| 5 |
+
In the ECDH feature, ecc_dsa_ctrl we check if the input publickey is on the curve but the flag which is set when publickey is valid is not used for any external output indicating the publickey is valid or invalid. Ideally, I expect an error in this whereas the error_flag is not set in this case.
|
| 6 |
+
|
| 7 |
+
[This line](https://github.com/chipsalliance/caliptra-rtl/blob/3964d76133a48befb0a192501e6f75b290e2d84e/src/ecc/rtl/ecc_dsa_ctrl.sv#L674) needs to be updated to validate pubkey in both verifying and ECDH flow.
|
| 8 |
+
|
| 9 |
+
PR Title: [RTL/VAL] Fix ECDH pubkey check
|
| 10 |
+
Status: Merged on July 14, 2025
|
| 11 |
+
|
| 12 |
+
Description:
|
| 13 |
+
The PR addresses a bug in the ECDH feature where the ecc_dsa_ctrl block performs internal validation of input public keys to verify they lie on the curve. The update ensures that invalid public keys properly trigger error conditions rather than proceeding silently.
|
| 14 |
+
|
| 15 |
+
Related Issue: #917 - "ECC pubkey check in ECDH"
|
| 16 |
+
|
| 17 |
+
Key Changes:
|
| 18 |
+
- Fixed ECDH public key validation logic
|
| 19 |
+
- Updated ECC test coverage
|
| 20 |
+
- Includes automated pipeline stamps with updated timestamps
|
| 21 |
+
|
| 22 |
+
Review & Approval:
|
| 23 |
+
Reviewers:
|
| 24 |
+
- Nitsirks (approved)
|
| 25 |
+
- calebofearth (approved and merged)
|
| 26 |
+
|
| 27 |
+
Participants: mojtaba-bisheh, calebofearth, Nitsirks
|
| 28 |
+
|
| 29 |
+
Commits (6 total):
|
| 30 |
+
Notable commits include:
|
| 31 |
+
- "fixed ECDH pbkey check"
|
| 32 |
+
- "updated ecc coverage"
|
| 33 |
+
- Merge commits integrating main branch updates
|
| 34 |
+
- Automated pipeline validation stamps
|
| 35 |
+
|
| 36 |
+
The pull request successfully passed 78 checks before merging.
|
issues/hdl-util_hdmi_pr15
ADDED
|
@@ -0,0 +1,37 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# add format 34 (1080p30)
|
| 2 |
+
|
| 3 |
+
Instance: hdl-util_hdmi_pr15
|
| 4 |
+
Source: https://github.com/hdl-util/hdmi/pull/15
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: hdl-util/hdmi
|
| 7 |
+
Pull request: #15
|
| 8 |
+
Author: sameer
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: 1080p30
|
| 12 |
+
Created: 2021-02-06T23:53:38Z
|
| 13 |
+
Updated: 2021-02-06T23:57:06Z
|
| 14 |
+
Closed: 2021-02-06T23:57:03Z
|
| 15 |
+
Merged: 2021-02-06T23:57:03Z
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
add format 34 (1080p30)
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
Derived from contributions by @nockieboy and BrianHG https://www.eevblog.com/forum/fpga/hdmi-dvi-encoder-with-audio-smart-quartus-pll-integration-in-systemverilog/
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
|
| 25 |
+
**sameer** (Feb 6, 2021):
|
| 26 |
+
"Derived from contributions by @nockieboy and BrianHG https://www.eevblog.com/forum/fpga/hdmi-dvi-encoder-with-audio-smart-quartus-pll-integration-in-systemverilog/"
|
| 27 |
+
|
| 28 |
+
## PR Metadata
|
| 29 |
+
- Status: Merged
|
| 30 |
+
- Merge commit: 2a35976
|
| 31 |
+
- Branch deleted after merge: 1080p30
|
| 32 |
+
- Reviewers: None
|
| 33 |
+
- Assignees: None
|
| 34 |
+
- Labels: None
|
| 35 |
+
|
| 36 |
+
## Linked Issues
|
| 37 |
+
No linked issues are referenced in this pull request.
|
issues/hdl-util_hdmi_pr23
ADDED
|
@@ -0,0 +1,19 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# add ip-less option for non intel/xilinx
|
| 2 |
+
|
| 3 |
+
Instance: hdl-util_hdmi_pr23
|
| 4 |
+
Source: https://github.com/hdl-util/hdmi/pull/23
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: hdl-util/hdmi
|
| 7 |
+
Pull request: #23
|
| 8 |
+
Author: sameer
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: no_ip
|
| 12 |
+
Created: 2021-03-07T17:43:44Z
|
| 13 |
+
Updated: 2021-03-07T18:05:15Z
|
| 14 |
+
Closed: 2021-03-07T18:05:11Z
|
| 15 |
+
Merged: 2021-03-07T18:05:11Z
|
| 16 |
+
|
| 17 |
+
This is the same implementation used in v1.1 but with added ip-less ddr io.
|
| 18 |
+
|
| 19 |
+
Hopefully it covers lattice and others but I don't know enough about those to confirm.
|
issues/jotego_jtcores_pr1100
ADDED
|
@@ -0,0 +1,21 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# riders -> lgtnfght: correctly implement dimming
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/jotego/jtcores/issues/1084
|
| 4 |
+
|
| 5 |
+
## Issue Title
|
| 6 |
+
riders -> lgtnfght: correctly implement dimming
|
| 7 |
+
|
| 8 |
+
## Issue Description
|
| 9 |
+
Currently (5c567cc92) only the Sunset Riders implementation is in place. The task involves implementing dimming functionality for the lgtnfght (Light Fighting) game on the existing core.
|
| 10 |
+
|
| 11 |
+
## Issue Comments
|
| 12 |
+
None visible.
|
| 13 |
+
|
| 14 |
+
## Issue Metadata
|
| 15 |
+
- Status: Closed (resolved via PR #1100)
|
| 16 |
+
- Assignees: jotego, rp-jt
|
| 17 |
+
- Labels: new game on existing core
|
| 18 |
+
- Project: JTCores
|
| 19 |
+
|
| 20 |
+
## Linked Issues / PRs
|
| 21 |
+
- PR #1100 — resolution
|
issues/jotego_jtcores_pr1177
ADDED
|
@@ -0,0 +1,20 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# support for SRAM memory on Analogue Pocket
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/jotego/jtcores/issues/1147
|
| 4 |
+
|
| 5 |
+
## Issue Title
|
| 6 |
+
support for SRAM memory on Analogue Pocket
|
| 7 |
+
|
| 8 |
+
## Issue Description
|
| 9 |
+
Add SRAM blocks to mem.yaml that can be enabled with macros.
|
| 10 |
+
|
| 11 |
+
## Issue Comments
|
| 12 |
+
None visible.
|
| 13 |
+
|
| 14 |
+
## Issue Metadata
|
| 15 |
+
- Status: Closed (linked to PR #1177)
|
| 16 |
+
- Assignee: jotego
|
| 17 |
+
- Project: JTCores (Status: Done)
|
| 18 |
+
|
| 19 |
+
## Linked Issues / PRs
|
| 20 |
+
- PR #1177 — resolution
|
issues/jotego_jtcores_pr1242
ADDED
|
@@ -0,0 +1,24 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# s18/wwallyj: missing borders
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/jotego/jtcores/issues/1061
|
| 4 |
+
|
| 5 |
+
## Issue Title
|
| 6 |
+
s18/wwallyj: missing borders
|
| 7 |
+
|
| 8 |
+
## Issue Description
|
| 9 |
+
Black borders are missing for the sprites shown when explaining how to play the game (ball, button, table, hands).
|
| 10 |
+
|
| 11 |
+
Comparison screenshots were provided: the current core output versus the original arcade video, highlighting the visual discrepancy in border rendering.
|
| 12 |
+
|
| 13 |
+
Arcade reference video: https://www.youtube.com/watch?v=Kn0mct3ZUk4
|
| 14 |
+
|
| 15 |
+
## Issue Comments
|
| 16 |
+
None visible.
|
| 17 |
+
|
| 18 |
+
## Issue Metadata
|
| 19 |
+
- Status: Closed (linked to PR #1242)
|
| 20 |
+
- Assignee: rp-jt
|
| 21 |
+
- Project: JTCores
|
| 22 |
+
|
| 23 |
+
## Linked Issues / PRs
|
| 24 |
+
- PR #1242 — resolution
|
issues/jotego_jtcores_pr951
ADDED
|
@@ -0,0 +1,23 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Screen rotation on SiDi128 is broken since version 6d1d2ef of cores
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/jotego/jtcores/issues/950
|
| 4 |
+
|
| 5 |
+
Commit 8d403ed broke screen rotation on SiDi128. `bitcounter` is set to a wrong value.
|
| 6 |
+
|
| 7 |
+
This works better:
|
| 8 |
+
|
| 9 |
+
```diff
|
| 10 |
+
--- a/modules/jtframe/hdl/video/rotate/unsigned_division.v
|
| 11 |
+
+++ b/modules/jtframe/hdl/video/rotate/unsigned_division.v
|
| 12 |
+
@@ -37,7 +37,7 @@ always @(posedge clk) begin
|
| 13 |
+
quot<=dividend;
|
| 14 |
+
div<=divisor;
|
| 15 |
+
/* verilator lint_off WIDTH */
|
| 16 |
+
- bitcounter<={widthlog2{1'd1}};
|
| 17 |
+
+ bitcounter<=(widthlog2[widthlog2-1:0]-1'd1);
|
| 18 |
+
/* verilator lint_on WIDTH */
|
| 19 |
+
state <= RUN;
|
| 20 |
+
end
|
| 21 |
+
```
|
| 22 |
+
|
| 23 |
+
Thanks!
|
issues/kumarrishav14_AMBA_APB_pr18
ADDED
|
@@ -0,0 +1,22 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Add dut
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/kumarrishav14/AMBA_APB/issues/15
|
| 4 |
+
|
| 5 |
+
Implement a DUT which is a simple memory having **APB interface**
|
| 6 |
+
|
| 7 |
+
## Fetched Issue/PR Details
|
| 8 |
+
|
| 9 |
+
Title: Add dut (#15)
|
| 10 |
+
|
| 11 |
+
Description: The issue requests implementation of a DUT (Device Under Test) component described as "a simple memory having APB interface."
|
| 12 |
+
|
| 13 |
+
Repository: kumarrishav14/AMBA_APB
|
| 14 |
+
Status: Closed (via PR #18)
|
| 15 |
+
Assignee: kumarrishav14
|
| 16 |
+
Label: New Feature
|
| 17 |
+
Milestone: version 1 release
|
| 18 |
+
Opened: November 10, 2020
|
| 19 |
+
|
| 20 |
+
Comments: No comments visible.
|
| 21 |
+
|
| 22 |
+
Linked Issues: Resolving PR #18.
|
issues/lowRISC_ibex_pr1839
ADDED
|
@@ -0,0 +1,34 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# [pmp] Instruction straddling two TOR regions cosim mismatch
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/lowRISC/ibex/pull/1839
|
| 4 |
+
|
| 5 |
+
When running the following test:
|
| 6 |
+
`make -j1 --keep-going IBEX_CONFIG=opentitan ITERATIONS=1 TEST=riscv_epmp_mml_test WAVES=0 COV=0 SEED=30325`
|
| 7 |
+
|
| 8 |
+
Ibex and Spike have different behavior. Spike throws an instruction access fault exception for the address `0x80005cc4`. The TOR region ends at `0x80005cc4`, which is the expected behavior.
|
| 9 |
+
|
| 10 |
+
I think Ibex somehow does not perform the check for fetched instructions properly. In this test case there is a branch instruction that straddles two PMP entries, so Ibex must do two requests.
|
| 11 |
+
|
| 12 |
+
Ibex commit: 0e396d594435c0acca9df785ac40309c76576cc3
|
| 13 |
+
Spike commit: 0dc2de5d76add7b218b31053792a676973034b9e
|
| 14 |
+
|
| 15 |
+
> estimate 4
|
| 16 |
+
|
| 17 |
+
## Fetched Issue/PR Details
|
| 18 |
+
|
| 19 |
+
Title: [if,pmp] Check second bit instead of third for instruction alignment (PR #1839)
|
| 20 |
+
|
| 21 |
+
Description: The PR addresses a bug where Ibex was checking the wrong bit when looking at PMP errors and when to count the error it received from instruction fetch +2. This PR closes issue #1837 ("[pmp] Instruction straddling two TOR regions cosim mismatch").
|
| 22 |
+
|
| 23 |
+
Status: Merged
|
| 24 |
+
Author: marnovandermaas
|
| 25 |
+
Merge Date: October 6, 2022
|
| 26 |
+
Reviewer: ctopal (approved)
|
| 27 |
+
Label: Type:Bug
|
| 28 |
+
|
| 29 |
+
Comments:
|
| 30 |
+
- marnovandermaas (Oct 5, 2022): Provided the description above and noted this fixes a cosmetic simulation mismatch related to PMP instruction alignment checking.
|
| 31 |
+
- ctopal (Oct 6, 2022): Approved the changes after reviewing file modifications.
|
| 32 |
+
- GregAC (Oct 6, 2022): Added the "Type:Bug" label to categorize this as a bug fix.
|
| 33 |
+
|
| 34 |
+
Linked Issues: Closes #1837 (the cosim mismatch reported above).
|
issues/lowRISC_ibex_pr1865
ADDED
|
@@ -0,0 +1,43 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
Observed Behavior
|
| 2 |
+
The core_busy_o output signal of the non-lockstep core is used to gate the core clock, which is used by the regular Ibex core and its lockstep counterpart.
|
| 3 |
+
|
| 4 |
+
ibex/rtl/ibex_top.sv
|
| 5 |
+
|
| 6 |
+
Lines 211 to 219 in 3943a4e
|
| 7 |
+
|
| 8 |
+
assign clock_en = core_busy_q | debug_req_i | irq_pending | irq_nm_i;
|
| 9 |
+
assign core_sleep_o = ~clock_en;
|
| 10 |
+
|
| 11 |
+
prim_clock_gating core_clock_gate_i (
|
| 12 |
+
.clk_i (clk_i),
|
| 13 |
+
.en_i (clock_en),
|
| 14 |
+
.test_en_i(test_en_i),
|
| 15 |
+
.clk_o (clk)
|
| 16 |
+
);
|
| 17 |
+
|
| 18 |
+
ibex/rtl/ibex_top.sv
|
| 19 |
+
|
| 20 |
+
Lines 286 to 287 in 3943a4e
|
| 21 |
+
|
| 22 |
+
) u_ibex_core (
|
| 23 |
+
.clk_i(clk),
|
| 24 |
+
|
| 25 |
+
ibex/rtl/ibex_top.sv
|
| 26 |
+
|
| 27 |
+
Lines 927 to 928 in 3943a4e
|
| 28 |
+
|
| 29 |
+
) u_ibex_lockstep (
|
| 30 |
+
.clk_i (clk),
|
| 31 |
+
This means that the lockstep core gets gated in the same clock cycle as the regular core, even though the lockstep core is a few cycles delayed. A low-glitch in the core_busy_o output of the non-lockstep core thus does not lead to a comparison mismatch and a major alert because the lockstep core is already clock-gated when it would produce the value of core_busy_o that is used in the comparison.
|
| 32 |
+
|
| 33 |
+
ibex/rtl/ibex_lockstep.sv
|
| 34 |
+
|
| 35 |
+
Lines 453 to 454 in 3943a4e
|
| 36 |
+
|
| 37 |
+
assign outputs_mismatch = enable_cmp_q & (shadow_outputs_q != core_outputs_q[0]);
|
| 38 |
+
assign alert_major_internal_o = outputs_mismatch | shadow_alert_major_internal;
|
| 39 |
+
Expected Behavior
|
| 40 |
+
A low-glitch/mismatch in the core_busy_o output signal of the non-lockstep core should lead to a major alert by the lockstep core.
|
| 41 |
+
|
| 42 |
+
Steps to reproduce the issue
|
| 43 |
+
Run the chip_sw_ibex_lockstep_glitch test in OpenTitan (currently in lowRISC/opentitan#15221) and override port_idx to the index of core_busy_o in output_ports.
|
issues/lowRISC_ibex_pr2261
ADDED
|
@@ -0,0 +1,90 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# simulator report error
|
| 2 |
+
|
| 3 |
+
<!--
|
| 4 |
+
Thank you for your interest in Ibex. We are continuously improving Ibex, and your bug report will help us with that. To help us understand and reproduce your problem as quickly as possible we have prepared a little template below.
|
| 5 |
+
|
| 6 |
+
No text in blocks starting with < !-- will be shown in the final bug report.
|
| 7 |
+
|
| 8 |
+
You can also copy/paste images into the bug report, and you can attach files to it by simply dragging them into the issue window.
|
| 9 |
+
-->
|
| 10 |
+
|
| 11 |
+
## Observed Behavior
|
| 12 |
+
Test ibex in verilator with cosim, simulator report error illegal instruction.
|
| 13 |
+
```
|
| 14 |
+
001003e8 <main>:
|
| 15 |
+
1003e8: 1141 addi sp,sp,-16
|
| 16 |
+
1003ea: c606 sw ra,12(sp)
|
| 17 |
+
1003ec: 0000 unimp # <--- This is the illegal instruction!
|
| 18 |
+
1003ee: 0000 unimp
|
| 19 |
+
1003f0: 37b9 jal 10033e <func>
|
| 20 |
+
1003f2: 00000517 auipc a0,0x0
|
| 21 |
+
1003f6: 05650513 addi a0,a0,86 # 100448 <main+0x60>
|
| 22 |
+
1003fa: 3959 jal 100090 <puts>
|
| 23 |
+
1003fc: 40b2 lw ra,12(sp)
|
| 24 |
+
1003fe: 4501 li a0,0
|
| 25 |
+
100400: 0141 addi sp,sp,16
|
| 26 |
+
100402: 8082 ret
|
| 27 |
+
```
|
| 28 |
+
```
|
| 29 |
+
DASM(0x00010413)
|
| 30 |
+
mv s0, sp
|
| 31 |
+
```
|
| 32 |
+
|
| 33 |
+

|
| 34 |
+
|
| 35 |
+
MTVAL in `ibex_simple_system.log` file is 0x00000000
|
| 36 |
+
<!--
|
| 37 |
+
Please describe the problem you saw. Include waveforms (in VCD or Verilator/GtkWave FST format only please) and log files if possible.
|
| 38 |
+
-->
|
| 39 |
+
|
| 40 |
+
## Expected Behavior
|
| 41 |
+
The terminal should print right mtval value.
|
| 42 |
+
<!-- Please describe the behavior you expected to see instead. -->
|
| 43 |
+
|
| 44 |
+
## Steps to reproduce the issue
|
| 45 |
+
Run `build/lowrisc_ibex_ibex_simple_system_cosim_0/sim-verilator/Vibex_simple_system --meminit=ram,ibex/examples/sw/simple_system/input/test.elf`
|
| 46 |
+
```
|
| 47 |
+
#include "simple_system_common.h"
|
| 48 |
+
int main(void){
|
| 49 |
+
// puts("Starting test");
|
| 50 |
+
__asm__ volatile(".word 0x000000");
|
| 51 |
+
puts("Test complete");
|
| 52 |
+
return 0;
|
| 53 |
+
}
|
| 54 |
+
```
|
| 55 |
+
<!--
|
| 56 |
+
Please help us to reproduce the issue you're seeing by including a detailed description of what you did to get to the problem.
|
| 57 |
+
|
| 58 |
+
For example:
|
| 59 |
+
* What command did you run? (Also include the output of the command.)
|
| 60 |
+
* What parameters/defines did you set?
|
| 61 |
+
* Did you make modifications to the source code?
|
| 62 |
+
-->
|
| 63 |
+
|
| 64 |
+
## My Environment
|
| 65 |
+
Build verilator to run ibex by [co-sim](https://ibex-core.readthedocs.io/en/latest/03_reference/cosim.html#quick-build-and-run-instructions).
|
| 66 |
+
<!--
|
| 67 |
+
Let us know how you're using Ibex. This helps us to better understand your problem and find a solution more quickly.
|
| 68 |
+
-->
|
| 69 |
+
|
| 70 |
+
**EDA tool and version:**
|
| 71 |
+
None
|
| 72 |
+
<!--
|
| 73 |
+
If you are using an EDA tool to work with Ibex let us know which tool and which version you're using.
|
| 74 |
+
For example, "Xilinx Vivado 2020.1" or "Synopsys VCS 2020.03-SP1"
|
| 75 |
+
-->
|
| 76 |
+
|
| 77 |
+
**Operating system:**
|
| 78 |
+
Ubuntu Linux 18.04
|
| 79 |
+
<!--
|
| 80 |
+
Please let us know the operating system/Linux distribution you're using.
|
| 81 |
+
For example "Ubuntu Linux 18.04" or "CentOS 7.3".
|
| 82 |
+
-->
|
| 83 |
+
|
| 84 |
+
**Version of the Ibex source code:**
|
| 85 |
+
8f4c75c5e43e61b994248307c814e01860303056
|
| 86 |
+
<!--
|
| 87 |
+
Which version of the Ibex source code are you using?
|
| 88 |
+
You can call `git rev-parse HEAD` in your Ibex source directory to get this information.
|
| 89 |
+
Please also let us know if you have made changes to the code.
|
| 90 |
+
-->
|
issues/muneeb-mbytes_pulpino__spi_master__ip_verification_pr42
ADDED
|
@@ -0,0 +1,53 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Develop the first testcase
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/muneeb-mbytes/pulpino__spi_master__ip_verification/issues/10
|
| 4 |
+
|
| 5 |
+
Title: Develop the first testcase #10
|
| 6 |
+
|
| 7 |
+
Body: We need to develop a testcase and run to check the flow
|
| 8 |
+
|
| 9 |
+
Comments: None
|
| 10 |
+
|
| 11 |
+
Linked PR: #42 (closed)
|
| 12 |
+
|
| 13 |
+
Metadata:
|
| 14 |
+
- Assignee: venkateshs-t
|
| 15 |
+
- Milestone: 💻 Development
|
| 16 |
+
- Status: Closed
|
| 17 |
+
- Created: February 5, 2022
|
| 18 |
+
- Author: muneebullashariff
|
| 19 |
+
|
| 20 |
+
---
|
| 21 |
+
|
| 22 |
+
## Pull Request
|
| 23 |
+
|
| 24 |
+
**PR Title:** [PR] :: Added Directed testcases for each feature mention in the following issues
|
| 25 |
+
|
| 26 |
+
**PR Number:** #42
|
| 27 |
+
|
| 28 |
+
**Status:** Merged on Feb 18, 2022
|
| 29 |
+
|
| 30 |
+
### Description
|
| 31 |
+
|
| 32 |
+
The contributor proposed synchronizing with the RTL VIPs integration branch and developing directed testcases aligned with feature requirements. Key accomplishments include:
|
| 33 |
+
|
| 34 |
+
- Created initial testcase with required sequences and virtual sequences
|
| 35 |
+
- Demonstrated data flow from APB master and SPI slave
|
| 36 |
+
- Developed directed testcases for features outlined in issue #41
|
| 37 |
+
|
| 38 |
+
**Testcases Added:**
|
| 39 |
+
Twelve testcases covering basic read/write operations, standard mode configurations with varying command/address/data lengths, dummy cycle generation, clock division settings (even/odd), and timing parameter variations.
|
| 40 |
+
|
| 41 |
+
### Comments
|
| 42 |
+
|
| 43 |
+
**venkateshs-t** (Feb 17, 2022):
|
| 44 |
+
"Fixes #10 #14 #41" - The contributor linked three related issues, indicating this work addresses multiple feature development and testing objectives.
|
| 45 |
+
|
| 46 |
+
**muneebullashariff** (Feb 18, 2022):
|
| 47 |
+
Approved changes with comment: "Accepting the changes"
|
| 48 |
+
|
| 49 |
+
### Linked Issues Closed
|
| 50 |
+
|
| 51 |
+
- Develop the first testcase (#10)
|
| 52 |
+
- Develop more tests (#14)
|
| 53 |
+
- Develop Directed Testcases (#41)
|
issues/muneeb-mbytes_pulpino__spi_master__ip_verification_pr56
ADDED
|
@@ -0,0 +1,26 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Incorrect Sampling of MOSI data
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/muneeb-mbytes/pulpino__spi_master__ip_verification/issues/46
|
| 4 |
+
|
| 5 |
+
**Brief explanation of the question/help**
|
| 6 |
+

|
| 7 |
+

|
| 8 |
+

|
| 9 |
+
|
| 10 |
+
if you can see in fig(1) the first 2 locked cursors shows 8 bits of command data
|
| 11 |
+
and 2nd block shows you the next 8 bits of address data
|
| 12 |
+
and the last block shows you the 32 bits of actual MOSI data
|
| 13 |
+
|
| 14 |
+
In fig(2) shows you the both MOSI data that has been sampled and MISO data that was driven
|
| 15 |
+
so if you observe MOSI data the MOSI[0] tells the first 8 bits of **CMD** data and MOSI[1] shows the next 8 bits of **ADDR** data and remaining four MOSI transfers shows the **actual data**
|
| 16 |
+
|
| 17 |
+
In fig(3) i have shown you the 8 bits of command data which is indicated by **SPICMD** label which is of **FF** but if you can observe the sampled command data in fig(2) it is **FE** there is 1 bit missing(last bit is supposed be 1 but it is sampling 0 this you can observe in fig(1))
|
| 18 |
+
|
| 19 |
+
Similarly for the address data bits and for the actual data bits there is miss match in data that has been send to the sampled data
|
| 20 |
+
|
| 21 |
+
**Branch name:** test_cases_branch
|
| 22 |
+
**Test_name:** apb_master_std_mode_write_8_cmd_8_addr_32_data_length_test.sv
|
| 23 |
+
|
| 24 |
+
**Add the required following items to the issue**
|
| 25 |
+
1. Projects
|
| 26 |
+
2. Milestone
|
issues/muneeb-mbytes_pulpino__spi_master__ip_verification_pr61
ADDED
|
@@ -0,0 +1,45 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Develop more test for covering the coverage holes
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/muneeb-mbytes/pulpino__spi_master__ip_verification/issues/18
|
| 4 |
+
|
| 5 |
+
Title: Develop more test for covering the coverage holes
|
| 6 |
+
|
| 7 |
+
Body: No description provided.
|
| 8 |
+
|
| 9 |
+
Comments: None
|
| 10 |
+
|
| 11 |
+
Linked PR: #61 (Closed)
|
| 12 |
+
|
| 13 |
+
Metadata:
|
| 14 |
+
- Assignee: venkateshs-t
|
| 15 |
+
- Milestone: 🥂 Coverage Closure
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
[PR] :: Testcases for Coverage closure
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
Fixes #18
|
| 22 |
+
|
| 23 |
+
Changes proposed in this pull request:
|
| 24 |
+
- Added more tests cases to cover the coverage holes as suggested
|
| 25 |
+
- added negative testcases for lsb shift
|
| 26 |
+
- added tx fifo testcase to hit the max count of fifo
|
| 27 |
+
- added the write test for 8 bit dummy cycles
|
| 28 |
+
|
| 29 |
+
Make sure you do the following:
|
| 30 |
+
- Create the pull request to branch development_branch_v1
|
| 31 |
+
- Use @mention to assign this pull request
|
| 32 |
+
- Select Reviewer
|
| 33 |
+
|
| 34 |
+
## PR Comments
|
| 35 |
+
|
| 36 |
+
**muneebullashariff** (March 14, 2022):
|
| 37 |
+
"Approved!"
|
| 38 |
+
|
| 39 |
+
## Linked Issue
|
| 40 |
+
#18: Develop more test for covering the coverage holes
|
| 41 |
+
|
| 42 |
+
## PR Metadata
|
| 43 |
+
- Author: venkateshs-t
|
| 44 |
+
- Reviewer/Merger: muneebullashariff
|
| 45 |
+
- Status: Merged (March 14, 2022)
|
issues/muneeb-mbytes_pulpino__spi_master__subsystem_verification_pr28
ADDED
|
@@ -0,0 +1,47 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Integrate RTL and VIPs
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/muneeb-mbytes/pulpino__spi_master__subsystem_verification/issues/4
|
| 4 |
+
|
| 5 |
+
Title: Integrate RTL and VIPs #4
|
| 6 |
+
|
| 7 |
+
Body: Integrate the RTL design and VIPs by developing the top module
|
| 8 |
+
|
| 9 |
+
Comments: None
|
| 10 |
+
|
| 11 |
+
Linked PR: #28 (Closed)
|
| 12 |
+
|
| 13 |
+
Metadata:
|
| 14 |
+
- Assignee: sivareddykostam
|
| 15 |
+
- Milestone: 💻 Development
|
| 16 |
+
- Status: Closed
|
| 17 |
+
|
| 18 |
+
## PR Title
|
| 19 |
+
Added the final width for the axi data
|
| 20 |
+
|
| 21 |
+
## PR Description
|
| 22 |
+
Fixes: #4 #2 #6
|
| 23 |
+
|
| 24 |
+
Changes proposed in this pull request:
|
| 25 |
+
- adding the .gitignore file
|
| 26 |
+
- updated the collector
|
| 27 |
+
|
| 28 |
+
Requirements checklist:
|
| 29 |
+
- Create the pull request to branch development_branch_v1
|
| 30 |
+
- Use @mention to assign this pull request
|
| 31 |
+
- Select Reviewer
|
| 32 |
+
|
| 33 |
+
## PR Comments
|
| 34 |
+
|
| 35 |
+
**sivareddykostam** (Mar 14, 2022):
|
| 36 |
+
"added the .gitignore file to remove the unwanted files"
|
| 37 |
+
|
| 38 |
+
## Linked Issue
|
| 39 |
+
#4: Integrate RTL and VIPs
|
| 40 |
+
|
| 41 |
+
## PR Metadata
|
| 42 |
+
- Author: sivareddykostam
|
| 43 |
+
- Source Branch: collector_branch
|
| 44 |
+
- Target Branch: development_branch_v1
|
| 45 |
+
- Assignee: sivareddykostam
|
| 46 |
+
- Milestone: 💻 Development
|
| 47 |
+
- Status: Merged (Mar 14, 2022)
|
issues/olofk_serv_pr105
ADDED
|
@@ -0,0 +1,38 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# alu with support for W=4
|
| 2 |
+
|
| 3 |
+
Instance: olofk_serv_pr105
|
| 4 |
+
Source: https://github.com/olofk/serv/pull/105
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: olofk/serv
|
| 7 |
+
Pull request: #105
|
| 8 |
+
Author: uhit332
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: main
|
| 11 |
+
Head branch: incremental
|
| 12 |
+
Created: 2023-10-31T11:31:13Z
|
| 13 |
+
Updated: 2023-10-31T11:42:58Z
|
| 14 |
+
Closed: 2023-10-31T11:42:52Z
|
| 15 |
+
Merged: 2023-10-31T11:42:52Z
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
alu with support for W=4
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
No description provided.
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
|
| 25 |
+
**uhit332** (Contributor, Oct 31, 2023):
|
| 26 |
+
No description provided.
|
| 27 |
+
|
| 28 |
+
**olofk** (Owner, Oct 31, 2023):
|
| 29 |
+
"Excellent! Approved"
|
| 30 |
+
|
| 31 |
+
## Linked Issues
|
| 32 |
+
No linked issues.
|
| 33 |
+
|
| 34 |
+
## PR Metadata
|
| 35 |
+
- Source branch: uhit332/serv:incremental
|
| 36 |
+
- Target branch: olofk/serv:main
|
| 37 |
+
- No reviews, assignees, labels, or milestone
|
| 38 |
+
- Merged by olofk on Oct 31, 2023 (commit 2e23b53)
|
issues/openhwgroup_cv32e40s_pr259
ADDED
|
@@ -0,0 +1,32 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Wrong execute permission with mseccfg.MML and no matching region
|
| 2 |
+
|
| 3 |
+
### Component
|
| 4 |
+
|
| 5 |
+
**Component:RTL**: For issues in the RTL (e.g. for files in the rtl directory)
|
| 6 |
+
|
| 7 |
+
### Steps to Reproduce
|
| 8 |
+
When the first instruction after reset sets mseccfg.MML, the fetch of the next instruction actually goes through. However, the Smepmp spec states that for MML set, "Executing code from a region without a matching rule or with a matching S/U-mode-only rule is denied." With no PMPs set up, the whole memory should thus be denied execute access after setting MML. This is also nicely illustrated in the picture in section 2.2: setting MML is enough to deny execute rights to M mode without a matching region.
|
| 9 |
+
The issue was found with assertion RV_chk.ops.XCPT_IF_ID_a of the OneSpin Processor Verification App.
|
| 10 |
+
|
| 11 |
+
## PR Title
|
| 12 |
+
PMP fix (issue 249)
|
| 13 |
+
|
| 14 |
+
## PR Description
|
| 15 |
+
Should fix #249
|
| 16 |
+
|
| 17 |
+
Signed-off-by: Arjan Bink <Arjan.Bink@silabs.com>
|
| 18 |
+
|
| 19 |
+
## PR Comments
|
| 20 |
+
|
| 21 |
+
**Silabs-ArjanB** (July 18, 2022):
|
| 22 |
+
"Should fix #249. Signed-off-by: Arjan Bink Arjan.Bink@silabs.com"
|
| 23 |
+
|
| 24 |
+
## Linked Issue
|
| 25 |
+
#249: Wrong execute permission with mseccfg.MML and no matching region
|
| 26 |
+
|
| 27 |
+
## PR Metadata
|
| 28 |
+
- Author: Silabs-ArjanB
|
| 29 |
+
- Reviewer: silabs-oivind (review requested)
|
| 30 |
+
- Labels: Component:RTL
|
| 31 |
+
- Status: Merged (July 18, 2022)
|
| 32 |
+
- Commit hash: 38ed6a0
|
issues/pulp-platform_apb_pr2
ADDED
|
@@ -0,0 +1,22 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# APB4 structs
|
| 2 |
+
|
| 3 |
+
Instance: pulp-platform_apb_pr2
|
| 4 |
+
Source: https://github.com/pulp-platform/apb/pull/2
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: pulp-platform/apb
|
| 7 |
+
Pull request: #2
|
| 8 |
+
Author: WRoenninger
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: apb-structs
|
| 12 |
+
Created: 2020-02-21T14:43:13Z
|
| 13 |
+
Updated: 2020-03-13T10:05:08Z
|
| 14 |
+
Closed: 2020-03-13T10:05:07Z
|
| 15 |
+
Merged: 2020-03-13T10:05:07Z
|
| 16 |
+
|
| 17 |
+
This PR mainly has the same changes as [#1](https://github.com/pulp-platform/apb/pull/1).
|
| 18 |
+
However this differs in the regard that the changes made here have the same structure as in the [AXI repository](https://github.com/pulp-platform/axi).
|
| 19 |
+
* Added struct typedef macros.
|
| 20 |
+
* Added struct assign macros.
|
| 21 |
+
* Added APB4 read only / write only registers (+testbenches).
|
| 22 |
+
* Added synthesis bench.
|
issues/pulp-platform_apb_pr3
ADDED
|
@@ -0,0 +1,20 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# apb_regs: Tool compatibility improvements
|
| 2 |
+
|
| 3 |
+
Instance: pulp-platform_apb_pr3
|
| 4 |
+
Source: https://github.com/pulp-platform/apb/pull/3
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: pulp-platform/apb
|
| 7 |
+
Pull request: #3
|
| 8 |
+
Author: zarubaf
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: tool-fixes
|
| 12 |
+
Created: 2020-04-23T07:10:42Z
|
| 13 |
+
Updated: 2026-02-14T23:10:27Z
|
| 14 |
+
Closed: 2022-12-02T15:03:23Z
|
| 15 |
+
Merged: 2022-12-02T15:03:23Z
|
| 16 |
+
|
| 17 |
+
- Some tools require explicit hints on the type
|
| 18 |
+
for the structured assignment.
|
| 19 |
+
- Reset values driven from signals are generally considered
|
| 20 |
+
unsafe. A tiny FSM initializes these values.
|
issues/pulp-platform_apb_pr8
ADDED
|
@@ -0,0 +1,35 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Adds an APB Error Slave
|
| 2 |
+
|
| 3 |
+
Instance: pulp-platform_apb_pr8
|
| 4 |
+
Source: https://github.com/pulp-platform/apb/pull/8
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: pulp-platform/apb
|
| 7 |
+
Pull request: #8
|
| 8 |
+
Author: meggiman
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: apb_err_slv
|
| 12 |
+
Created: 2022-12-05T20:41:29Z
|
| 13 |
+
Updated: 2026-02-14T23:10:24Z
|
| 14 |
+
Closed: 2022-12-20T12:13:33Z
|
| 15 |
+
Merged: 2022-12-20T12:13:33Z
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
Adds an APB Error Slave
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
Depends on #7
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
|
| 25 |
+
**meggiman** (Dec 5, 2022):
|
| 26 |
+
"Depends on #7"
|
| 27 |
+
|
| 28 |
+
**meggiman** (Dec 20, 2022):
|
| 29 |
+
Marked the pull request as ready for review.
|
| 30 |
+
|
| 31 |
+
**paulsc96** (Dec 20, 2022):
|
| 32 |
+
Force-pushed changes and merged commit c736c05 into master.
|
| 33 |
+
|
| 34 |
+
## Linked Issues
|
| 35 |
+
No linked issues are referenced in this pull request.
|
issues/pulp-platform_axi_pr74
ADDED
|
@@ -0,0 +1,25 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Verilator compile issues
|
| 2 |
+
|
| 3 |
+
I am working on simulating the AXI4 code in Verilator and are running into a problem with the parameter types of the modules. The issue is the `parameter type resp_t = logic` definition in al modules. However renaming the definitions to `parameter type rsp_t = logic` seems to not trigger the issue. I think the issue could be that in `axi_pkg` the parameter `resp_t` is already defined and part of the response struct which is the parameter which has this problem.
|
| 4 |
+
Should I do a fix for all modules, this will however break all other projects which are using the new AXI4 infrastructure currently.
|
| 5 |
+
|
| 6 |
+
Related to Verilator: In #43 there is in file `src/axi_dw_upsizer.sv` line 321 a struct definition for `r_req_d` and `r_req_q` inside a generate. Verilator complains about multiple type definitions.
|
| 7 |
+
I was able to fix this by declaring a separate typedef outside the generate and defining the signals separate in the generate:
|
| 8 |
+
|
| 9 |
+
```systemverilog
|
| 10 |
+
typedef struct packed {
|
| 11 |
+
ar_chan_t ar ;
|
| 12 |
+
logic ar_valid ;
|
| 13 |
+
logic ar_throw_error ;
|
| 14 |
+
slv_r_chan_t r ;
|
| 15 |
+
logic r_valid ;
|
| 16 |
+
burst_len_t burst_len;
|
| 17 |
+
size_t orig_ar_size ;
|
| 18 |
+
} r_req_t;
|
| 19 |
+
|
| 20 |
+
// code
|
| 21 |
+
|
| 22 |
+
for (genvar ...
|
| 23 |
+
r_req_t r_req_d, r_req_q;
|
| 24 |
+
end
|
| 25 |
+
```
|
issues/pulp-platform_axi_riscv_atomics_pr15
ADDED
|
@@ -0,0 +1,52 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Guarantee atomicity by tracking downstream transactions
|
| 2 |
+
|
| 3 |
+
Instance: pulp-platform_axi_riscv_atomics_pr15
|
| 4 |
+
Source: https://github.com/pulp-platform/axi_riscv_atomics/pull/15
|
| 5 |
+
Fetched: 2026-05-03
|
| 6 |
+
Repository: pulp-platform/axi_riscv_atomics
|
| 7 |
+
Pull request: #15
|
| 8 |
+
Author: SamuelRiedel
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: testbench
|
| 12 |
+
Created: 2022-02-23
|
| 13 |
+
Updated: 2022-03-11
|
| 14 |
+
Closed: 2022-03-11
|
| 15 |
+
Merged: 2022-03-11
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
Guarantee atomicity by tracking downstream transactions
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
This PR adds several updates to the axi_riscv_atomics repository:
|
| 22 |
+
|
| 23 |
+
- `axi_riscv_lrsc`: Tracks downstream writes to guarantee atomicity, addressing cases where reads can overtake writes in the downstream AXI bus, violating atomicity guarantees.
|
| 24 |
+
- `axi_riscv_amos`: Uses the updated `axi_riscv_lrsc` module to guarantee atomicity of atomic memory operations without duplicating logic; translates AMOs into LR and SC operations.
|
| 25 |
+
- `axi_riscv_atomics_tb`: Adds a testbench to verify both modules together.
|
| 26 |
+
|
| 27 |
+
The PR initially contained a bug identified in issue #16, which was subsequently fixed.
|
| 28 |
+
|
| 29 |
+
## PR Comments
|
| 30 |
+
|
| 31 |
+
**SamuelRiedel** (Feb 23, 2022):
|
| 32 |
+
Requested review from andreaskurth, noting the PR contains WIP commits that looked good and offering to split into multiple PRs if preferred.
|
| 33 |
+
|
| 34 |
+
**SamuelRiedel** (Mar 11, 2022):
|
| 35 |
+
Indicated readiness pending AXI upstream changes and official release.
|
| 36 |
+
|
| 37 |
+
**andreaskurth** (Mar 11, 2022):
|
| 38 |
+
Approved changes; released axi v0.35.0.
|
| 39 |
+
|
| 40 |
+
**SamuelRiedel** (Mar 11, 2022):
|
| 41 |
+
Confirmed new AXI release works as expected; approved for merge.
|
| 42 |
+
|
| 43 |
+
## Linked Issues
|
| 44 |
+
|
| 45 |
+
**Issue #3: Add unit and top-level TBs to repo**
|
| 46 |
+
Requires some common verification modules to be updated first.
|
| 47 |
+
|
| 48 |
+
**Issue #4: Fix ordering guarantees for multiple outstanding and conflicting SWs/SCs/AMOs**
|
| 49 |
+
(Closed by this PR; body not available.)
|
| 50 |
+
|
| 51 |
+
**Issue #16: typedef typo in axi_riscv_lrsc.sv**
|
| 52 |
+
(Closed by this PR; body not available.)
|
issues/pulp-platform_axi_riscv_atomics_pr27
ADDED
|
@@ -0,0 +1,32 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# [fix] lrsc: Add missing sequential logic for aw_wait reg
|
| 2 |
+
|
| 3 |
+
Instance: pulp-platform_axi_riscv_atomics_pr27
|
| 4 |
+
Source: https://github.com/pulp-platform/axi_riscv_atomics/pull/27
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: pulp-platform/axi_riscv_atomics
|
| 7 |
+
Pull request: #27
|
| 8 |
+
Author: niwis
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: fix/aw_wait
|
| 12 |
+
Created: 2023-08-02T15:42:06Z
|
| 13 |
+
Updated: 2023-08-02T20:47:22Z
|
| 14 |
+
Closed: 2023-08-02T16:42:57Z
|
| 15 |
+
Merged: 2023-08-02T16:42:57Z
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
[fix] lrsc: Add missing sequential logic for aw_wait reg
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
Not sure how this was missed so far.
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
|
| 25 |
+
**niwis** (Aug 2, 2023):
|
| 26 |
+
"Not sure how this was missed so far"
|
| 27 |
+
|
| 28 |
+
**SamuelRiedel** (Aug 2, 2023):
|
| 29 |
+
"Thanks! I also wonder how we could have missed this. But it indicates that the testbench never reaches the `AW_BURST` state. We have to double-check this."
|
| 30 |
+
|
| 31 |
+
## Linked Issues
|
| 32 |
+
No linked issues are referenced in this pull request.
|
issues/pulp-platform_axi_riscv_atomics_pr31
ADDED
|
@@ -0,0 +1,37 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# lrsc: Fix burst invalidation length
|
| 2 |
+
|
| 3 |
+
Instance: pulp-platform_axi_riscv_atomics_pr31
|
| 4 |
+
Source: https://github.com/pulp-platform/axi_riscv_atomics/pull/31
|
| 5 |
+
Fetched: 2026-05-03
|
| 6 |
+
Repository: pulp-platform/axi_riscv_atomics
|
| 7 |
+
Pull request: #31
|
| 8 |
+
Author: niwis
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: nwistoff/lrsc-burst-len
|
| 12 |
+
Created: 2023-10-02
|
| 13 |
+
Updated: 2023-10-05
|
| 14 |
+
Closed: 2023-10-05
|
| 15 |
+
Merged: 2023-10-05
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
lrsc: Fix burst invalidation length
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
Terminate invalidation after the last beat. Fixes #30.
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
|
| 25 |
+
**niwis** (Oct 2, 2023):
|
| 26 |
+
Requested review from SamuelRiedel.
|
| 27 |
+
|
| 28 |
+
**SamuelRiedel** (Oct 5, 2023):
|
| 29 |
+
Force-pushed the branch with commit 427f84d.
|
| 30 |
+
|
| 31 |
+
**SamuelRiedel** (Oct 5, 2023):
|
| 32 |
+
Merged commit 424697e into master and deleted the nwistoff/lrsc-burst-len branch.
|
| 33 |
+
|
| 34 |
+
## Linked Issues
|
| 35 |
+
|
| 36 |
+
**Issue #30: AW burst of length N clears N+1 addresses**
|
| 37 |
+
When an AW burst of length N with start address A is sent to the axi_riscv_lrsc module, it submits a check+clear request for addresses [A, A+N], but the correct range would be [A, A+(N-1)]. Probably it would be sufficient to change line 761 from `clr_len_d = aw_res_len - 1;` to `clr_len_d = aw_res_len - 2;`.
|
issues/pulp-platform_carfield_pr41
ADDED
|
@@ -0,0 +1,49 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Add atomics support to shared L2 memory
|
| 2 |
+
|
| 3 |
+
Instance: pulp-platform_carfield_pr41
|
| 4 |
+
Source: https://github.com/pulp-platform/carfield/pull/41
|
| 5 |
+
Fetched: 2026-05-03
|
| 6 |
+
Repository: pulp-platform/carfield
|
| 7 |
+
Pull request: #41
|
| 8 |
+
Author: alex96295
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: main
|
| 11 |
+
Head branch: aottaviano/l2-atomics
|
| 12 |
+
Created: 2023-05-17
|
| 13 |
+
Updated: 2023-05-30
|
| 14 |
+
Closed: 2023-05-30
|
| 15 |
+
Merged: 2023-05-30
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
Add atomics support to shared L2 memory
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
Expose extra parameters to config the `axi_riscv_atomics_structs`. They default to Cheshire, which is fine for now. Fixes #34.
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
|
| 25 |
+
**alex96295** (May 17, 2023):
|
| 26 |
+
"Expose extra parameters to config the `axi_riscv_atomics_structs`. They default to Cheshire, which is fine for now."
|
| 27 |
+
|
| 28 |
+
**husterZC** (May 17, 2023):
|
| 29 |
+
"Aha ;) , Thanks Ale!"
|
| 30 |
+
|
| 31 |
+
**husterZC** (May 17, 2023):
|
| 32 |
+
"Should we also change the `Bender.lock` there?"
|
| 33 |
+
|
| 34 |
+
**alex96295** (May 17, 2023):
|
| 35 |
+
"I upstreamed it"
|
| 36 |
+
|
| 37 |
+
**alex96295** (May 21, 2023):
|
| 38 |
+
"Rebased onto main"
|
| 39 |
+
|
| 40 |
+
**alex96295** (May 30, 2023):
|
| 41 |
+
"Rebased onto main"
|
| 42 |
+
|
| 43 |
+
**alex96295** (May 30, 2023):
|
| 44 |
+
"lgtm"
|
| 45 |
+
|
| 46 |
+
## Linked Issues
|
| 47 |
+
|
| 48 |
+
**Issue #34: Check `atomics`: `axi_riscv_atomics_structs` before the L2 SPM**
|
| 49 |
+
Atomics support is needed towards every memory inside `carfield`. `Cheshire` already instantiates `axi_riscv_atomics_structs` before the main memory, the debug module and the `idma` slave port. We need it before the `L2SPM`.
|